Patchwork UBUNTU: Enable perf tools on armel

login
register
mail settings
Submitter Loïc Minier
Date May 14, 2010, 7:55 a.m.
Message ID <1273823739-6458-1-git-send-email-loic.minier@ubuntu.com>
Download mbox | patch
Permalink /patch/52582/
State Accepted
Delegated to: Leann Ogasawara
Headers show

Comments

Loïc Minier - May 14, 2010, 7:55 a.m.
Signed-off-by: Loïc Minier <loic.minier@ubuntu.com>
---
 debian.master/rules.d/armel.mk |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Tim Gardner - May 14, 2010, 12:42 p.m.
On 05/14/2010 09:55 AM, Loïc Minier wrote:
> Signed-off-by: Loïc Minier<loic.minier@ubuntu.com>
> ---
>   debian.master/rules.d/armel.mk |    2 --
>   1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/debian.master/rules.d/armel.mk b/debian.master/rules.d/armel.mk
> index 2924a39..79428e3 100644
> --- a/debian.master/rules.d/armel.mk
> +++ b/debian.master/rules.d/armel.mk
> @@ -7,7 +7,5 @@ build_image	= zImage
>   kernel_file	= arch/$(build_arch)/boot/zImage
>   install_file	= vmlinuz
>   no_dumpfile = true
> -# ARM is not a supported architecture in perf userspace
> -do_tools	= false
>
>   loader		= grub

I assume this is for Maverick? If so,

Acked-by: Tim Gardner <tim.gardner@canonical.com>
Loïc Minier - May 14, 2010, 3:43 p.m.
On Fri, May 14, 2010, Tim Gardner wrote:
> >-# ARM is not a supported architecture in perf userspace
> >-do_tools	= false
> I assume this is for Maverick? If so,

 Correct

 BTW I was told this build, but didn't verify myself
Andy Whitcroft - May 15, 2010, 6:18 a.m.
On Fri, May 14, 2010 at 05:43:45PM +0200, Loïc Minier wrote:
> On Fri, May 14, 2010, Tim Gardner wrote:
> > >-# ARM is not a supported architecture in perf userspace
> > >-do_tools	= false
> > I assume this is for Maverick? If so,
> 
>  Correct
> 
>  BTW I was told this build, but didn't verify myself

Leann, as I have a work item to investigate this I'll get this one
tested with Lioc and report back.

-apw
Andy Whitcroft - May 21, 2010, 10:28 a.m.
On Sat, May 15, 2010 at 07:18:53AM +0100, Andy Whitcroft wrote:
> On Fri, May 14, 2010 at 05:43:45PM +0200, Loïc Minier wrote:
> > On Fri, May 14, 2010, Tim Gardner wrote:
> > > >-# ARM is not a supported architecture in perf userspace
> > > >-do_tools	= false
> > > I assume this is for Maverick? If so,
> > 
> >  Correct
> > 
> >  BTW I was told this build, but didn't verify myself
> 
> Leann, as I have a work item to investigate this I'll get this one
> tested with Lioc and report back.

Ok, after much futzing about I managed to get a build environment setup
which could actually build the binary programs part and we ended up with
a linux-tools for armel on versatile.  So I am happy that this should
not cause an FTBS for armel.  With that I suggest we get this applied to
it can be tested in the real builds:

Acked-by: Andy Whitcroft <apw@canonical.com>

-apw
Leann Ogasawara - May 21, 2010, 3:16 p.m.
Applied to Maverick master.

Thanks,
Leann

Patch

diff --git a/debian.master/rules.d/armel.mk b/debian.master/rules.d/armel.mk
index 2924a39..79428e3 100644
--- a/debian.master/rules.d/armel.mk
+++ b/debian.master/rules.d/armel.mk
@@ -7,7 +7,5 @@  build_image	= zImage
 kernel_file	= arch/$(build_arch)/boot/zImage
 install_file	= vmlinuz
 no_dumpfile = true
-# ARM is not a supported architecture in perf userspace
-do_tools	= false
 
 loader		= grub