diff mbox

[v3,1/4] package/kodi-pvr-stalker: Needs jsoncpp

Message ID 1443803497-9936-1-git-send-email-bernd.kuhls@t-online.de
State Accepted
Commit 0a9a71ff6bcb6e7e08d24bcb31073ba127b14764
Headers show

Commit Message

Bernd Kuhls Oct. 2, 2015, 4:31 p.m. UTC
Fixes
http://autobuild.buildroot.net/results/56f/56fb98da27495f6a461bfdc7aa8c2de4d86dfdb8/
http://autobuild.buildroot.net/results/f98/f982b437935cf1f921559f5388fd4146eb9241bd/

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
v3: removed reference to c++ from comment (Baruch)
v2: add jsoncpp reverse dependency (Baruch)

 package/kodi-pvr-stalker/Config.in           | 5 +++++
 package/kodi-pvr-stalker/kodi-pvr-stalker.mk | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

Comments

Yann E. MORIN Oct. 2, 2015, 10:04 p.m. UTC | #1
Bernd, All,

On 2015-10-02 18:31 +0200, Bernd Kuhls spake thusly:
> Fixes
> http://autobuild.buildroot.net/results/56f/56fb98da27495f6a461bfdc7aa8c2de4d86dfdb8/
> http://autobuild.buildroot.net/results/f98/f982b437935cf1f921559f5388fd4146eb9241bd/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
> v3: removed reference to c++ from comment (Baruch)
> v2: add jsoncpp reverse dependency (Baruch)
> 
>  package/kodi-pvr-stalker/Config.in           | 5 +++++
>  package/kodi-pvr-stalker/kodi-pvr-stalker.mk | 2 +-
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/package/kodi-pvr-stalker/Config.in b/package/kodi-pvr-stalker/Config.in
> index b327fd8..26a8c3f 100644
> --- a/package/kodi-pvr-stalker/Config.in
> +++ b/package/kodi-pvr-stalker/Config.in
> @@ -1,7 +1,12 @@
>  config BR2_PACKAGE_KODI_PVR_STALKER
>  	bool "kodi-pvr-stalker"
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp
> +	select BR2_PACKAGE_JSONCPP
>  	select BR2_PACKAGE_KODI_PLATFORM
>  	help
>  	  A PVR Client that connects Kodi to Stalker Middleware
>  
>  	  https://github.com/kodi-pvr/pvr.stalker
> +
> +comment "kodi-pvr-stalker needs a toolchain w/ gcc >= 4.7"
> +	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7
> diff --git a/package/kodi-pvr-stalker/kodi-pvr-stalker.mk b/package/kodi-pvr-stalker/kodi-pvr-stalker.mk
> index 589cf7d..c1baa8d 100644
> --- a/package/kodi-pvr-stalker/kodi-pvr-stalker.mk
> +++ b/package/kodi-pvr-stalker/kodi-pvr-stalker.mk
> @@ -8,6 +8,6 @@ KODI_PVR_STALKER_VERSION = 5f6eb1992ffd45a075ebb7bc4253c4a88bf65c80
>  KODI_PVR_STALKER_SITE = $(call github,kodi-pvr,pvr.stalker,$(KODI_PVR_STALKER_VERSION))
>  KODI_PVR_STALKER_LICENSE = GPLv2+
>  KODI_PVR_STALKER_LICENSE_FILES = src/client.h
> -KODI_PVR_STALKER_DEPENDENCIES = kodi-platform
> +KODI_PVR_STALKER_DEPENDENCIES = jsoncpp kodi-platform
>  
>  $(eval $(cmake-package))
> -- 
> 2.5.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard Oct. 3, 2015, 1:24 p.m. UTC | #2
>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:

 > Fixes
 > http://autobuild.buildroot.net/results/56f/56fb98da27495f6a461bfdc7aa8c2de4d86dfdb8/
 > http://autobuild.buildroot.net/results/f98/f982b437935cf1f921559f5388fd4146eb9241bd/

 > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
 > ---
 > v3: removed reference to c++ from comment (Baruch)
 > v2: add jsoncpp reverse dependency (Baruch)

Committed all 4, thanks.
diff mbox

Patch

diff --git a/package/kodi-pvr-stalker/Config.in b/package/kodi-pvr-stalker/Config.in
index b327fd8..26a8c3f 100644
--- a/package/kodi-pvr-stalker/Config.in
+++ b/package/kodi-pvr-stalker/Config.in
@@ -1,7 +1,12 @@ 
 config BR2_PACKAGE_KODI_PVR_STALKER
 	bool "kodi-pvr-stalker"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp
+	select BR2_PACKAGE_JSONCPP
 	select BR2_PACKAGE_KODI_PLATFORM
 	help
 	  A PVR Client that connects Kodi to Stalker Middleware
 
 	  https://github.com/kodi-pvr/pvr.stalker
+
+comment "kodi-pvr-stalker needs a toolchain w/ gcc >= 4.7"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7
diff --git a/package/kodi-pvr-stalker/kodi-pvr-stalker.mk b/package/kodi-pvr-stalker/kodi-pvr-stalker.mk
index 589cf7d..c1baa8d 100644
--- a/package/kodi-pvr-stalker/kodi-pvr-stalker.mk
+++ b/package/kodi-pvr-stalker/kodi-pvr-stalker.mk
@@ -8,6 +8,6 @@  KODI_PVR_STALKER_VERSION = 5f6eb1992ffd45a075ebb7bc4253c4a88bf65c80
 KODI_PVR_STALKER_SITE = $(call github,kodi-pvr,pvr.stalker,$(KODI_PVR_STALKER_VERSION))
 KODI_PVR_STALKER_LICENSE = GPLv2+
 KODI_PVR_STALKER_LICENSE_FILES = src/client.h
-KODI_PVR_STALKER_DEPENDENCIES = kodi-platform
+KODI_PVR_STALKER_DEPENDENCIES = jsoncpp kodi-platform
 
 $(eval $(cmake-package))