| Message ID | 1443730437-12443-1-git-send-email-bernd.kuhls@t-online.de |
|---|---|
| State | Superseded |
| Headers | show |
Hi Benrd, On Thu, Oct 01, 2015 at 10:13:57PM +0200, Bernd Kuhls wrote: > diff --git a/package/kodi-pvr-stalker/Config.in > b/package/kodi-pvr-stalker/Config.in > index b327fd8..0e6143a 100644 > --- a/package/kodi-pvr-stalker/Config.in > +++ b/package/kodi-pvr-stalker/Config.in > @@ -1,7 +1,12 @@ > config BR2_PACKAGE_KODI_PVR_STALKER > bool "kodi-pvr-stalker" > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp Also BR2_INSTALL_LIBSTDCPP. > + select BR2_PACKAGE_JSONCPP > select BR2_PACKAGE_KODI_PLATFORM > help > A PVR Client that connects Kodi to Stalker Middleware > > https://github.com/kodi-pvr/pvr.stalker > + > +comment "kodi-pvr-stalker needs a toolchain w/ C++, gcc >= 4.7" > + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 Ditto. baruch
[posted and mailed] Baruch Siach <baruch@tkos.co.il> wrote in news:20151001202438.GE3337@tarshish: > Hi Benrd, > > On Thu, Oct 01, 2015 at 10:13:57PM +0200, Bernd Kuhls wrote: >> diff --git a/package/kodi-pvr-stalker/Config.in >> b/package/kodi-pvr-stalker/Config.in >> index b327fd8..0e6143a 100644 >> --- a/package/kodi-pvr-stalker/Config.in >> +++ b/package/kodi-pvr-stalker/Config.in >> @@ -1,7 +1,12 @@ >> config BR2_PACKAGE_KODI_PVR_STALKER >> bool "kodi-pvr-stalker" >> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp > > Also BR2_INSTALL_LIBSTDCPP. Hi Baruch, imho this is not necessary, BR2_PACKAGE_KODI_PVR_STALKER can only be selected if BR2_PACKAGE_KODI is true and BR2_PACKAGE_KODI already depends on BR2 _INSTALL_LIBSTDCPP. Regards, Bernd
Hi Bernd, On Thu, Oct 01, 2015 at 10:28:23PM +0200, Bernd Kuhls wrote: > Baruch Siach <baruch@tkos.co.il> wrote in > news:20151001202438.GE3337@tarshish: > > On Thu, Oct 01, 2015 at 10:13:57PM +0200, Bernd Kuhls wrote: > >> diff --git a/package/kodi-pvr-stalker/Config.in > >> b/package/kodi-pvr-stalker/Config.in > >> index b327fd8..0e6143a 100644 > >> --- a/package/kodi-pvr-stalker/Config.in > >> +++ b/package/kodi-pvr-stalker/Config.in > >> @@ -1,7 +1,12 @@ > >> config BR2_PACKAGE_KODI_PVR_STALKER > >> bool "kodi-pvr-stalker" > >> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp > > > > Also BR2_INSTALL_LIBSTDCPP. > > imho this is not necessary, BR2_PACKAGE_KODI_PVR_STALKER can only be selected > if BR2_PACKAGE_KODI is true and BR2_PACKAGE_KODI already depends on BR2 > _INSTALL_LIBSTDCPP. In that case the comment doesn't even show when the toolchain lacks C++ support, so I guess you can just omit C++ from the toolchain requirements comment. baruch
diff --git a/package/kodi-pvr-stalker/Config.in b/package/kodi-pvr-stalker/Config.in index b327fd8..0e6143a 100644 --- a/package/kodi-pvr-stalker/Config.in +++ b/package/kodi-pvr-stalker/Config.in @@ -1,7 +1,12 @@ config BR2_PACKAGE_KODI_PVR_STALKER bool "kodi-pvr-stalker" + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp + select BR2_PACKAGE_JSONCPP select BR2_PACKAGE_KODI_PLATFORM help A PVR Client that connects Kodi to Stalker Middleware https://github.com/kodi-pvr/pvr.stalker + +comment "kodi-pvr-stalker needs a toolchain w/ C++, gcc >= 4.7" + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 diff --git a/package/kodi-pvr-stalker/kodi-pvr-stalker.mk b/package/kodi-pvr-stalker/kodi-pvr-stalker.mk index 589cf7d..c1baa8d 100644 --- a/package/kodi-pvr-stalker/kodi-pvr-stalker.mk +++ b/package/kodi-pvr-stalker/kodi-pvr-stalker.mk @@ -8,6 +8,6 @@ KODI_PVR_STALKER_VERSION = 5f6eb1992ffd45a075ebb7bc4253c4a88bf65c80 KODI_PVR_STALKER_SITE = $(call github,kodi-pvr,pvr.stalker,$(KODI_PVR_STALKER_VERSION)) KODI_PVR_STALKER_LICENSE = GPLv2+ KODI_PVR_STALKER_LICENSE_FILES = src/client.h -KODI_PVR_STALKER_DEPENDENCIES = kodi-platform +KODI_PVR_STALKER_DEPENDENCIES = jsoncpp kodi-platform $(eval $(cmake-package))
Fixes http://autobuild.buildroot.net/results/56f/56fb98da27495f6a461bfdc7aa8c2de4d86dfdb8/ http://autobuild.buildroot.net/results/f98/f982b437935cf1f921559f5388fd4146eb9241bd/ Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> --- v2: add jsoncpp reverse dependency (Baruch) package/kodi-pvr-stalker/Config.in | 5 +++++ package/kodi-pvr-stalker/kodi-pvr-stalker.mk | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-)