| Message ID | 1443684964-342-3-git-send-email-bmeng.cn@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Simon Glass |
| Headers | show |
On 1 October 2015 at 08:36, Bin Meng <bmeng.cn@gmail.com> wrote: > When pci_find_class() fails to find a device, it returns -ENODEV. > But now we check the return value against -1. Fix it. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > --- > > drivers/video/vesa_fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Simon Glass <sjg@chromium.org>
On Thu, 1 Oct 2015 00:36:00 -0700 Bin Meng <bmeng.cn@gmail.com> wrote: > When pci_find_class() fails to find a device, it returns -ENODEV. > But now we check the return value against -1. Fix it. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > --- > > drivers/video/vesa_fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Anatolij Gustschin <agust@denx.de>
On 7 October 2015 at 12:40, Anatolij Gustschin <agust@denx.de> wrote: > On Thu, 1 Oct 2015 00:36:00 -0700 > Bin Meng <bmeng.cn@gmail.com> wrote: > >> When pci_find_class() fails to find a device, it returns -ENODEV. >> But now we check the return value against -1. Fix it. >> >> Signed-off-by: Bin Meng <bmeng.cn@gmail.com> >> --- >> >> drivers/video/vesa_fb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Acked-by: Anatolij Gustschin <agust@denx.de> Applied to u-boot-x86, thanks!
diff --git a/drivers/video/vesa_fb.c b/drivers/video/vesa_fb.c index 4e6d070..a19651f 100644 --- a/drivers/video/vesa_fb.c +++ b/drivers/video/vesa_fb.c @@ -34,7 +34,7 @@ void *video_hw_init(void) } if (vbe_get_video_info(gdev)) { dev = pci_find_class(PCI_CLASS_DISPLAY_VGA << 8, 0); - if (dev == -1) { + if (dev < 0) { printf("no card detected\n"); return NULL; }
When pci_find_class() fails to find a device, it returns -ENODEV. But now we check the return value against -1. Fix it. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> --- drivers/video/vesa_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)