Patchwork musicpal: Drop redundant reset call

login
register
mail settings
Submitter Jan Kiszka
Date May 13, 2010, 1:09 p.m.
Message ID <4BEBFA26.50300@web.de>
Download mbox | patch
Permalink /patch/52482/
State New
Headers show

Comments

Jan Kiszka - May 13, 2010, 1:09 p.m.
Reset is now triggered after init, no need for explicit calls anymore.

Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
---
 hw/musicpal.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Aurelien Jarno - May 28, 2010, 7:49 p.m.
On Thu, May 13, 2010 at 03:09:58PM +0200, Jan Kiszka wrote:
> Reset is now triggered after init, no need for explicit calls anymore.

Thanks, applied.

> Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
> ---
>  hw/musicpal.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/musicpal.c b/hw/musicpal.c
> index ebd933e..d44c5a0 100644
> --- a/hw/musicpal.c
> +++ b/hw/musicpal.c
> @@ -1295,8 +1295,6 @@ static int musicpal_gpio_init(SysBusDevice *dev)
>                                         musicpal_gpio_writefn, s);
>      sysbus_init_mmio(dev, MP_GPIO_SIZE, iomemtype);
>  
> -    musicpal_gpio_reset(&dev->qdev);
> -
>      qdev_init_gpio_out(&dev->qdev, s->out, ARRAY_SIZE(s->out));
>  
>      qdev_init_gpio_in(&dev->qdev, musicpal_gpio_pin_event, 32);
> -- 
> 1.6.0.2
>

Patch

diff --git a/hw/musicpal.c b/hw/musicpal.c
index ebd933e..d44c5a0 100644
--- a/hw/musicpal.c
+++ b/hw/musicpal.c
@@ -1295,8 +1295,6 @@  static int musicpal_gpio_init(SysBusDevice *dev)
                                        musicpal_gpio_writefn, s);
     sysbus_init_mmio(dev, MP_GPIO_SIZE, iomemtype);
 
-    musicpal_gpio_reset(&dev->qdev);
-
     qdev_init_gpio_out(&dev->qdev, s->out, ARRAY_SIZE(s->out));
 
     qdev_init_gpio_in(&dev->qdev, musicpal_gpio_pin_event, 32);