| Message ID | 1443681874-28145-1-git-send-email-mpe@ellerman.id.au (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, 2015-01-10 at 06:44:31 UTC, Michael Ellerman wrote: > The pseries build with PCI=n looks to have been broken for at least 5 > years, and no one's noticed or cared. > > Following the obvious breakages backward, the first commit I can find > that builds is the parent of 2eb4afb69ff3 ("powerpc/pci: Move pseries > code into pseries platform specific area") from April 2009. > > A distro would never ship a PCI=n kernel, so it is only useful for folks > building custom kernels. Also on KVM the virtio devices appear on PCI, > so it would only be useful if you were building kernels specifically to > run on PowerVM and with no PCI devices. > > The added code complexity, and testing load (which we've clearly not > been doing), is not justified by the small reduction in kernel size for > such a niche use case. > > So just make PCI non-optional on pseries. > > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Series applied to powerpc next. https://git.kernel.org/powerpc/c/4c9cd468b348c9e47f9380a5 cheers
diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig index 54c87d5d349d..d9068a3d6af4 100644 --- a/arch/powerpc/platforms/pseries/Kconfig +++ b/arch/powerpc/platforms/pseries/Kconfig @@ -4,6 +4,7 @@ config PPC_PSERIES select HAVE_PCSPKR_PLATFORM select MPIC select OF_DYNAMIC + select PCI select PCI_MSI select PPC_XICS select PPC_ICP_NATIVE @@ -15,7 +16,6 @@ config PPC_PSERIES select RTAS_ERROR_LOGGING select PPC_UDBG_16550 select PPC_NATIVE - select PPC_PCI_CHOICE if EXPERT select PPC_DOORBELL select HAVE_CONTEXT_TRACKING select HOTPLUG_CPU if SMP
The pseries build with PCI=n looks to have been broken for at least 5 years, and no one's noticed or cared. Following the obvious breakages backward, the first commit I can find that builds is the parent of 2eb4afb69ff3 ("powerpc/pci: Move pseries code into pseries platform specific area") from April 2009. A distro would never ship a PCI=n kernel, so it is only useful for folks building custom kernels. Also on KVM the virtio devices appear on PCI, so it would only be useful if you were building kernels specifically to run on PowerVM and with no PCI devices. The added code complexity, and testing load (which we've clearly not been doing), is not justified by the small reduction in kernel size for such a niche use case. So just make PCI non-optional on pseries. Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> --- arch/powerpc/platforms/pseries/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)