| Message ID | 1443648649-24599-3-git-send-email-aalonso@freescale.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
Hi Adrian, On 30/09/2015 23:30, Adrian Alonso wrote: > Add CONFIG_ROM_UNIFIED_SECTIONS for mx6sx and mx6ul > target platforms to resolve corresponding HAB_RVT_BASE > This is the only explanation for the patch. It does not explain the name ROM_UNIFIED_SECTION and what it has to do with HAB_RVT_BASE. I agree that users must read the manual, but even a better and longer description in the commit message helps. > Signed-off-by: Adrian Alonso <aalonso@freescale.com> > --- > Chages for V2: New patch in series > > arch/arm/include/asm/imx-common/hab.h | 2 +- > include/configs/mx6_common.h | 4 ++++ > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/include/asm/imx-common/hab.h b/arch/arm/include/asm/imx-common/hab.h > index d0eaa67..af77d45 100644 > --- a/arch/arm/include/asm/imx-common/hab.h > +++ b/arch/arm/include/asm/imx-common/hab.h > @@ -113,7 +113,7 @@ typedef void hapi_clock_init_t(void); > #define HAB_ENG_RTL 0x77 /* RTL simulation engine */ > #define HAB_ENG_SW 0xff /* Software engine */ > > -#ifdef CONFIG_MX6SX > +#ifdef CONFIG_ROM_UNIFIED_SECTIONS > #define HAB_RVT_BASE 0x00000100 > #else > #define HAB_RVT_BASE 0x00000094 > diff --git a/include/configs/mx6_common.h b/include/configs/mx6_common.h > index ef4cb68..3c7138a 100644 > --- a/include/configs/mx6_common.h > +++ b/include/configs/mx6_common.h > @@ -117,4 +117,8 @@ > #define CONFIG_CMD_FUSE > #define CONFIG_MXC_OCOTP > > +#if (defined(CONFIG_MX6SX) || defined(CONFIG_MX6UL)) > +#define CONFIG_ROM_UNIFIED_SECTIONS > +#endif > + > #endif This is not ok. We are in the process to move all CONFIG_ from the board configuration file to Kconfig. New CONFIG_ should be added only via Kconfig. As ROM_UNIFIED_SECTIONS is like a property for the SOC, the selection of the SOC type must add automatically it to the config. You can see as example SYS_L2CACHE_OFF for i.mx6ul. Best regards, Stefano Babic
diff --git a/arch/arm/include/asm/imx-common/hab.h b/arch/arm/include/asm/imx-common/hab.h index d0eaa67..af77d45 100644 --- a/arch/arm/include/asm/imx-common/hab.h +++ b/arch/arm/include/asm/imx-common/hab.h @@ -113,7 +113,7 @@ typedef void hapi_clock_init_t(void); #define HAB_ENG_RTL 0x77 /* RTL simulation engine */ #define HAB_ENG_SW 0xff /* Software engine */ -#ifdef CONFIG_MX6SX +#ifdef CONFIG_ROM_UNIFIED_SECTIONS #define HAB_RVT_BASE 0x00000100 #else #define HAB_RVT_BASE 0x00000094 diff --git a/include/configs/mx6_common.h b/include/configs/mx6_common.h index ef4cb68..3c7138a 100644 --- a/include/configs/mx6_common.h +++ b/include/configs/mx6_common.h @@ -117,4 +117,8 @@ #define CONFIG_CMD_FUSE #define CONFIG_MXC_OCOTP +#if (defined(CONFIG_MX6SX) || defined(CONFIG_MX6UL)) +#define CONFIG_ROM_UNIFIED_SECTIONS +#endif + #endif
Add CONFIG_ROM_UNIFIED_SECTIONS for mx6sx and mx6ul target platforms to resolve corresponding HAB_RVT_BASE Signed-off-by: Adrian Alonso <aalonso@freescale.com> --- Chages for V2: New patch in series arch/arm/include/asm/imx-common/hab.h | 2 +- include/configs/mx6_common.h | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-)