diff mbox

kvm-unit-tests: arm: Fail on unknown subtest

Message ID 1443539307-20690-1-git-send-email-cov@codeaurora.org
State New
Headers show

Commit Message

Christopher Covington Sept. 29, 2015, 3:08 p.m. UTC 
Signed-off-by: Christopher Covington <cov@codeaurora.org>
---
 arm/selftest.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Andrew Jones Sept. 29, 2015, 3:47 p.m. UTC | #1 
On Tue, Sep 29, 2015 at 11:08:27AM -0400, Christopher Covington wrote:
> Signed-off-by: Christopher Covington <cov@codeaurora.org>
> ---
>  arm/selftest.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arm/selftest.c b/arm/selftest.c
> index fc9ec60..aa16a91 100644
> --- a/arm/selftest.c
> +++ b/arm/selftest.c
> @@ -376,6 +376,8 @@ int main(int argc, char **argv)
>  		cpumask_set_cpu(0, &smp_reported);
>  		while (!cpumask_full(&smp_reported))
>  			cpu_relax();
> +	} else {
> +		report("Unknown subtest", false);

I think

 printf("Unknown subtest\n");
 abort();

might be better. Also, please post kvm-unit-tests patches to the
kvm mailing list.

Thanks,
drew

>  	}
>  
>  	return report_summary();
> -- 
> Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
diff mbox

Patch

diff --git a/arm/selftest.c b/arm/selftest.c
index fc9ec60..aa16a91 100644
--- a/arm/selftest.c
+++ b/arm/selftest.c
@@ -376,6 +376,8 @@  int main(int argc, char **argv)
 		cpumask_set_cpu(0, &smp_reported);
 		while (!cpumask_full(&smp_reported))
 			cpu_relax();
+	} else {
+		report("Unknown subtest", false);
 	}
 
 	return report_summary();