| Message ID | 1443636820-17083-6-git-send-email-tycho.andersen@canonical.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
diff --git a/net/core/filter.c b/net/core/filter.c index 70995dd..5a4596b 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -845,8 +845,7 @@ int bpf_prog_store_orig_filter(struct bpf_prog *fp, fkprog = fp->orig_prog; fkprog->len = fprog->len; - fkprog->filter = kmemdup(fp->insns, fsize, - GFP_KERNEL | __GFP_NOWARN); + fkprog->filter = memdup_user(fprog->filter, fsize); if (!fkprog->filter) { kfree(fp->orig_prog); return -ENOMEM;
In some cases (e.g. seccomp) the program result might be translated from the original program the user supplied. If we're saving the result for checkpoint/restore, we should save exactly the program the user initially supplied. This causes problems when the translations seccomp makes are not allowed by bpf_check_classic. Signed-off-by: Tycho Andersen <tycho.andersen@canonical.com> CC: Kees Cook <keescook@chromium.org> CC: Will Drewry <wad@chromium.org> CC: Oleg Nesterov <oleg@redhat.com> CC: Andy Lutomirski <luto@amacapital.net> CC: Pavel Emelyanov <xemul@parallels.com> CC: Serge E. Hallyn <serge.hallyn@ubuntu.com> CC: Alexei Starovoitov <ast@kernel.org> CC: Daniel Borkmann <daniel@iogearbox.net> --- net/core/filter.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)