From patchwork Tue Sep 29 19:06:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Pfaff X-Patchwork-Id: 523992 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (li376-54.members.linode.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 221BD14029C for ; Wed, 30 Sep 2015 05:06:35 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id C7E431069B; Tue, 29 Sep 2015 12:06:34 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx1e4.cudamail.com (mx1.cudamail.com [69.90.118.67]) by archives.nicira.com (Postfix) with ESMTPS id 59C5A10691 for ; Tue, 29 Sep 2015 12:06:33 -0700 (PDT) Received: from bar5.cudamail.com (unknown [192.168.21.12]) by mx1e4.cudamail.com (Postfix) with ESMTPS id BCD851E023C for ; Tue, 29 Sep 2015 13:06:32 -0600 (MDT) X-ASG-Debug-ID: 1443553592-09eadd11e46c2990001-byXFYA Received: from mx1-pf1.cudamail.com ([192.168.24.1]) by bar5.cudamail.com with ESMTP id UOkm992usYhKcKta (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 29 Sep 2015 13:06:32 -0600 (MDT) X-Barracuda-Envelope-From: blp@nicira.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.24.1 Received: from unknown (HELO mail-pa0-f47.google.com) (209.85.220.47) by mx1-pf1.cudamail.com with ESMTPS (RC4-SHA encrypted); 29 Sep 2015 19:06:32 -0000 Received-SPF: unknown (mx1-pf1.cudamail.com: Multiple SPF records returned) X-Barracuda-RBL-Trusted-Forwarder: 209.85.220.47 Received: by pacfv12 with SMTP id fv12so14328527pac.2 for ; Tue, 29 Sep 2015 12:06:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=WGVEnIWN/q8IhE6I+0TCXfi3eYujIYwUzsuUCWF7pWE=; b=RDFC5BxAgarZrQ19bKhlUXY9z4G4/vElvobgmCWT0hk660ufwMsNTrKGwqAuhNbJB+ vwLDUW0dn4sfuN+BJEdsnWZ+wydE0MoyaBA0Wz5QzoyXyouoRk1rBMkN6ln4yOy1GVd+ 3N2cjXC+OmyEOA3Gsc6daPq+ZDOt4UXI9fxa6E7DAf9UmWuSrPSd/Cd4E6toUF6UjK7T 32o6IfhlCvKc544QP2cTtALkQpZdRJ+xXamPla9AIi7No75/PflJu5ijtj49/aRJQuSe vW6XWX3OCfih4309M9HAVRYafurzTFdgDr/+PWh5xiVp6oVPfIW9pn1+amwHsjDVhgX5 lD9g== X-Gm-Message-State: ALoCoQmvkVmaQvjppOJapdKGdm1no/wsNaRdaq7WWJQulP87vAUdEDL5xz+nd3sonDjqJp6HBqaQ X-Received: by 10.68.92.1 with SMTP id ci1mr34739882pbb.155.1443553590947; Tue, 29 Sep 2015 12:06:30 -0700 (PDT) Received: from nicira.com ([208.91.2.4]) by smtp.gmail.com with ESMTPSA id py6sm26972200pbb.62.2015.09.29.12.06.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Sep 2015 12:06:29 -0700 (PDT) Date: Tue, 29 Sep 2015 12:06:27 -0700 X-Barracuda-Apparent-Source-IP: 208.91.2.4 X-CudaMail-Envelope-Sender: blp@nicira.com From: Ben Pfaff To: Gurucharan Shetty X-CudaMail-Whitelist-To: dev@openvswitch.org X-CudaMail-MID: CM-E1-928085846 X-CudaMail-DTE: 092915 X-CudaMail-Originating-IP: 209.85.220.47 Message-ID: <20150929190627.GM30384@nicira.com> X-ASG-Orig-Subj: [##CM-E1-928085846##]Re: [ovs-dev] [PATCH 2/3] ovn-controller: Fix a case wherein tag can be zero. References: <1443548047-13144-1-git-send-email-gshetty@nicira.com> <1443548047-13144-2-git-send-email-gshetty@nicira.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1443548047-13144-2-git-send-email-gshetty@nicira.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Barracuda-Connect: UNKNOWN[192.168.24.1] X-Barracuda-Start-Time: 1443553592 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-ASG-Whitelist: Header =?UTF-8?B?eFwtY3VkYW1haWxcLXdoaXRlbGlzdFwtdG8=?= X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 2/3] ovn-controller: Fix a case wherein tag can be zero. X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@openvswitch.org Sender: "dev" On Tue, Sep 29, 2015 at 10:34:06AM -0700, Gurucharan Shetty wrote: > If the ovn-nb DB's logical_port table is populated such > that tag is zero, we should not consider that record. > > Signed-off-by: Gurucharan Shetty I thought that the intention was that tag=0 was for "control" traffic into the VM, for managing the containers. If tag=0 should be invalid then we should disallow it in the schema: diff --git a/ovn/ovn-sb.ovsschema b/ovn/ovn-sb.ovsschema index 1ffd1b4..7f857ed 100644 --- a/ovn/ovn-sb.ovsschema +++ b/ovn/ovn-sb.ovsschema @@ -86,7 +86,7 @@ "parent_port": {"type": {"key": "string", "min": 0, "max": 1}}, "tag": { "type": {"key": {"type": "integer", - "minInteger": 0, + "minInteger": 1, "maxInteger": 4095}, "min": 0, "max": 1}}, "chassis": {"type": {"key": {"type": "uuid",