[ovs-dev,3/3] ovn-controller: Fix container flows in table 33.
diff mbox

Message ID 1443548047-13144-3-git-send-email-gshetty@nicira.com
State Accepted
Headers show

Commit Message

Gurucharan Shetty Sept. 29, 2015, 5:34 p.m. UTC
The broadcast flows added in table 33 was faulty for
containers. Fix it.

Suggested-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
---
 ovn/controller/physical.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Russell Bryant Sept. 29, 2015, 5:51 p.m. UTC | #1
On 09/29/2015 01:34 PM, Gurucharan Shetty wrote:
> The broadcast flows added in table 33 was faulty for
> containers. Fix it.
> 
> Suggested-by: Russell Bryant <rbryant@redhat.com>
> Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>

I'm not sure if my ack is appropriate if I suggested it, but:

Acked-by: Russell Bryant <rbryant@redhat.com>
Gurucharan Shetty Sept. 29, 2015, 6:21 p.m. UTC | #2
>
> Acked-by: Russell Bryant <rbryant@redhat.com>

Thanks for the review. I applied the series to master.

>
> --
> Russell Bryant

Patch
diff mbox

diff --git a/ovn/controller/physical.c b/ovn/controller/physical.c
index 5280916..fc70748 100644
--- a/ovn/controller/physical.c
+++ b/ovn/controller/physical.c
@@ -474,7 +474,9 @@  physical_run(struct controller_ctx *ctx, enum mf_field_id mff_ovn_geneve,
                 continue;
             }
 
-            if (simap_contains(&localvif_to_ofport, port->logical_port)) {
+            if (simap_contains(&localvif_to_ofport,
+                               port->parent_port
+                               ? port->parent_port : port->logical_port)) {
                 put_load(port->tunnel_key, MFF_LOG_OUTPORT, 0, 32, &ofpacts);
                 put_resubmit(OFTABLE_DROP_LOOPBACK, &ofpacts);
             } else if (port->chassis) {