From patchwork Mon Sep 28 06:47:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 523235 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (unknown [IPv6:2600:3c00::f03c:91ff:fe6e:bdf7]) by ozlabs.org (Postfix) with ESMTP id 11F91140157 for ; Mon, 28 Sep 2015 16:47:41 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 5ECC510523; Sun, 27 Sep 2015 23:47:40 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx1e3.cudamail.com (mx1.cudamail.com [69.90.118.67]) by archives.nicira.com (Postfix) with ESMTPS id 88CAE1051F for ; Sun, 27 Sep 2015 23:47:39 -0700 (PDT) Received: from bar5.cudamail.com (localhost [127.0.0.1]) by mx1e3.cudamail.com (Postfix) with ESMTPS id 9D0FF420597 for ; Mon, 28 Sep 2015 00:47:38 -0600 (MDT) X-ASG-Debug-ID: 1443422857-09eadd11e05b1ff0001-byXFYA Received: from mx1-pf1.cudamail.com ([192.168.24.1]) by bar5.cudamail.com with ESMTP id m4kipTkPV8pHbBVY (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 28 Sep 2015 00:47:37 -0600 (MDT) X-Barracuda-Envelope-From: i.maximets@samsung.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.24.1 Received: from unknown (HELO mailout1.w1.samsung.com) (210.118.77.11) by mx1-pf1.cudamail.com with ESMTPS (DHE-RSA-AES128-SHA encrypted); 28 Sep 2015 06:47:37 -0000 Received-SPF: none (mx1-pf1.cudamail.com: domain at samsung.com does not designate permitted sender hosts) X-Barracuda-Apparent-Source-IP: 210.118.77.11 X-Barracuda-RBL-IP: 210.118.77.11 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NVD00FUFK79Q910@mailout1.w1.samsung.com> for dev@openvswitch.org; Mon, 28 Sep 2015 07:47:33 +0100 (BST) X-AuditID: cbfec7f5-f794b6d000001495-89-5608e285dd1e Received: from eusync1.samsung.com ( [203.254.199.211]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 3A.EC.05269.582E8065; Mon, 28 Sep 2015 07:47:33 +0100 (BST) Received: from imaximets.rnd.samsung.ru ([106.109.129.180]) by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NVD00GVLK750E40@eusync1.samsung.com>; Mon, 28 Sep 2015 07:47:33 +0100 (BST) X-CudaMail-Envelope-Sender: i.maximets@samsung.com From: Ilya Maximets To: dev@openvswitch.org X-CudaMail-MID: CM-E1-927001285 X-CudaMail-DTE: 092815 X-CudaMail-Originating-IP: 210.118.77.11 Date: Mon, 28 Sep 2015 09:47:27 +0300 X-ASG-Orig-Subj: [##CM-E1-927001285##][PATCH] dpif-netdev: emc_processing: remove useless instruction Message-id: <1443422847-10911-1-git-send-email-i.maximets@samsung.com> X-Mailer: git-send-email 2.1.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGJMWRmVeSWpSXmKPExsVy+t/xy7qtjzjCDOa3y1j8WN/JZnH09B5m i5fd99gtrrT/ZLeYs3wBo8Xfm8+YLSbPlnJg9zhwdDuLx7Ob/xk9+rasYvR4N/8tWwBLFJdN SmpOZllqkb5dAlfGj47EgiOsFQsPvGJvYNzI0sXIySEhYCJxaOZ9RghbTOLCvfVsXYxcHEIC Sxklbty6wQjhtDJJvJl9mg2kik1AR+LU6iNgHSIC4hLbO5YygxQxC3xmlNh3fSWQw8EhLOAh sXlWHUgNi4CqxJeF91lBbF4BN4ljC7czQWyTkzh//CfzBEbuBYwMqxhFU0uTC4qT0nON9IoT c4tL89L1kvNzNzFCQuPrDsalx6wOMQpwMCrx8M5U5wgTYk0sK67MPcQowcGsJMLrcxgoxJuS WFmVWpQfX1Sak1p8iFGag0VJnHfmrvchQgLpiSWp2ampBalFMFkmDk6pBsY0UeXZnc8Yb3Ue fjtB68Uv9y2Cy/PtCvsXr74h23VWbRrz3ZP3PmsIzX+YUhCndvZ4tBLbpug8iYj7Cp1/oq6v 63ulpBqr/r/3d8sPTruGoxMOCceHqux4W3vh69Z/LmzL3zXZln5ljGZy1Cxp1OpInfrQ8ezF +6KPPv/d4W33OdzN6tT2tTVKLMUZiYZazEXFiQApctjcCQIAAA== X-GBUdb-Analysis: 0, 210.118.77.11, Ugly c=0 p=0 Source New X-MessageSniffer-Rules: 0-0-0-3937-c X-Barracuda-Connect: UNKNOWN[192.168.24.1] X-Barracuda-Start-Time: 1443422857 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-ASG-Whitelist: EmailCat (corporate) Cc: Dyasly Sergey , Ilya Maximets Subject: [ovs-dev] [PATCH] dpif-netdev: emc_processing: remove useless instruction X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" key.len, if needed, will be initialized inside fast_path_processing(). It will be never used before. Signed-off-by: Ilya Maximets --- lib/dpif-netdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index e6ba33f..54626b9 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -3220,7 +3220,6 @@ emc_processing(struct dp_netdev_pmd_thread *pmd, struct dp_packet **packets, } miniflow_extract(packets[i], &key.mf); - key.len = 0; /* Not computed yet. */ key.hash = dpif_netdev_packet_get_rss_hash(packets[i], &key.mf); flow = emc_lookup(flow_cache, &key);