diff mbox

[01/36] qapi: add comment block before ChardevDummy

Message ID 1443189844-20341-2-git-send-email-marcandre.lureau@redhat.com
State New
Headers show

Commit Message

Marc-André Lureau Sept. 25, 2015, 2:03 p.m. UTC
From: Marc-André Lureau <marcandre.lureau@redhat.com>

This is mainly to please the doc generation that requires comment block
before the declaration.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 qapi-schema.json | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Eric Blake Sept. 25, 2015, 3:03 p.m. UTC | #1
On 09/25/2015 08:03 AM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> This is mainly to please the doc generation that requires comment block
> before the declaration.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  qapi-schema.json | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

Could be taken through trivial branch now without waiting for pending
qapi patches, hence I've added a cc.

> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 516c95b..3e2e53d 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3042,13 +3042,17 @@
>  { 'struct': 'ChardevRingbuf', 'data': { '*size'  : 'int' } }
>  
>  ##
> +# @ChardevDummy
> +##
> +{ 'struct': 'ChardevDummy', 'data': { } }

I might eventually reach the point where we could use:

{ 'union': 'ChardevBackend', 'data': { ...
  'pty': {},
... } }

instead of needing 'pty': 'ChardevDummy'.  But my current pending series
doesn't get us quite there yet, so it would be a separate cleanup anyways.
diff mbox

Patch

diff --git a/qapi-schema.json b/qapi-schema.json
index 516c95b..3e2e53d 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3042,13 +3042,17 @@ 
 { 'struct': 'ChardevRingbuf', 'data': { '*size'  : 'int' } }
 
 ##
+# @ChardevDummy
+##
+{ 'struct': 'ChardevDummy', 'data': { } }
+
+##
 # @ChardevBackend:
 #
 # Configuration info for the new chardev backend.
 #
 # Since: 1.4 (testdev since 2.2)
 ##
-{ 'struct': 'ChardevDummy', 'data': { } }
 
 { 'union': 'ChardevBackend', 'data': { 'file'   : 'ChardevFile',
                                        'serial' : 'ChardevHostdev',