diff mbox

[gomp4] lock/unlock internal fn

Message ID 87bnctxixy.fsf@kepler.schwinge.homeip.net
State New
Headers show

Commit Message

Thomas Schwinge Sept. 23, 2015, 3:18 p.m. UTC 
Hi!

On Wed, 23 Sep 2015 10:19:15 -0400, Nathan Sidwell <nathan@codesourcery.com> wrote:
> On 09/23/15 10:16, Thomas Schwinge wrote:
> > On Wed, 23 Sep 2015 08:40:51 -0400, Nathan Sidwell <nathan@codesourcery.com> wrote:
> >> On 09/23/15 05:27, Thomas Schwinge wrote:
> >>> On Mon, 17 Aug 2015 15:30:16 -0400, Nathan Sidwell <nathan@acm.org> wrote:
> >>>> I've committed this patch to add a new pair of internal functions.  These will
> >>>> be used in implementing reductions.

> >>> With the __builtin_nvptx_lock and __builtin_nvptx_unlock builtins
> >>> removed, should the gcc.target/nvptx/spinlock-1.c and
> >>> gcc.target/nvptx/spinlock-2.c test cases then be removed, too, or should
> >>> these be re-written differently?
> >>
> >> confused.  I don't think I remoced those locks.  Certainly didn't intend to, and
> >> I would have expected massive test fails if I had.
> >
> > You didn't remove the functionality, but you did remove the
> > __builtin_nvptx_lock and __builtin_nvptx_unlock builtins (which the two
> > test cases were written for), replacing them with GOACC_LOCK/GOACC_UNLOCK
> > internal functions, nvptx_expand_oacc_lock_unlock.
> 
> ah, thanks. I expect even these are going to go away soon. the spinlock 
> testcases should be removed.

Committed to gomp-4_0-branch in r228055:

commit fa0a1ef0b746e6f2f7c54f5516ee2c8ebe05cf25
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Wed Sep 23 15:16:05 2015 +0000

    [nvptx] Remove obsolete spinlock test cases
    
    	gcc/testsuite/
    	* gcc.target/nvptx/spinlock-1.c: Remove file.
    	* gcc.target/nvptx/spinlock-2.c: Likewise.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@228055 138bc75d-0d04-0410-961f-82ee72b054a4
---
 gcc/testsuite/ChangeLog.gomp                |    5 +++++
 gcc/testsuite/gcc.target/nvptx/spinlock-1.c |   11 -----------
 gcc/testsuite/gcc.target/nvptx/spinlock-2.c |   10 ----------
 3 files changed, 5 insertions(+), 21 deletions(-)



Grüße,
 Thomas
diff mbox

Patch

diff --git gcc/testsuite/ChangeLog.gomp gcc/testsuite/ChangeLog.gomp
index b14167e..1e7667d 100644
--- gcc/testsuite/ChangeLog.gomp
+++ gcc/testsuite/ChangeLog.gomp
@@ -1,3 +1,8 @@ 
+2015-09-23  Thomas Schwinge  <thomas@codesourcery.com>
+
+	* gcc.target/nvptx/spinlock-1.c: Remove file.
+	* gcc.target/nvptx/spinlock-2.c: Likewise.
+
 2015-09-18  Thomas Schwinge  <thomas@codesourcery.com>
 
 	* gcc.target/nvptx/spinlock-1.c: Fix DejaGnu directives.
diff --git gcc/testsuite/gcc.target/nvptx/spinlock-1.c gcc/testsuite/gcc.target/nvptx/spinlock-1.c
deleted file mode 100644
index b464ad9..0000000
--- gcc/testsuite/gcc.target/nvptx/spinlock-1.c
+++ /dev/null
@@ -1,11 +0,0 @@ 
-/* { dg-do compile } */
-void Foo ()
-{
-  __builtin_nvptx_lock (0);
-  __builtin_nvptx_unlock (0);
-}
-
-
-/* { dg-final { scan-assembler-times ".atom.global.cas.b32" 2 } } */
-/* { dg-final { scan-assembler ".global .u32 __global_lock;" } } */
-/* { dg-final { scan-assembler-not ".shared .u32 __shared_lock;" } } */
diff --git gcc/testsuite/gcc.target/nvptx/spinlock-2.c gcc/testsuite/gcc.target/nvptx/spinlock-2.c
deleted file mode 100644
index 9a51d3f..0000000
--- gcc/testsuite/gcc.target/nvptx/spinlock-2.c
+++ /dev/null
@@ -1,10 +0,0 @@ 
-/* { dg-do compile } */
-void Foo ()
-{
-  __builtin_nvptx_lock (1);
-  __builtin_nvptx_unlock (1);
-}
-
-/* { dg-final { scan-assembler-times ".atom.shared.cas.b32" 2 } } */
-/* { dg-final { scan-assembler ".shared .u32 __shared_lock;" } } */
-/* { dg-final { scan-assembler-not ".global .u32 __global_lock;" } } */