Message ID | 1442843618.3106.1.camel@canonical.com |
---|---|
State | New |
Headers | show |
Looks good. There appears to be little chance of regression for non-arm64 platforms.
On 21.09.2015 15:53, Craig Magina wrote:
> git://kernel.ubuntu.com/cmagina/vivid-xgene.git 1494357
0001-EDAC-Cleanup-atomic_scrub-mess.patch
This renames an inline function. For the in-kernel code not that much
of a deal but if there are any external drivers anywhere which rely on
asm/edac.h this API change may cause trouble.
0002-arm64-Enable-EDAC-on-ARM64.patch
Looks ok.
0003-MAINTAINERS-Add-entry-for-APM-X-Gene-SoC-EDAC-driver.patch
Looks safe.
0004-Documentation-Add-documentation-for-the-APM-X-Gene-S.patch
Looks safe.
0005-EDAC-Add-APM-X-Gene-SoC-EDAC-driver.patch
Not sure what exactly "dropped suggested merge changes" means but otherwise
only adding a new driver. Should not cause regressions.
0006-arm64-Add-APM-X-Gene-SoC-EDAC-DTS-entries.patch
Only device tree change, so at least no effect on other arches.
0007-EDAC-edac_stub-Drop-arch-specific-include.patch
Dropping an include file. Should be harmless but is it needed?
0008-UBUNTU-Config-Add-XGENE_EDAC-EDAC_SUPPORT-and-EDAC_A.patch
Looks ok.
So 0001 may pose a risk for breaking API. 0003 and 0004 might not strictly be
required but good to include for completeness and pose no risk. 0007 does not
look strictly required at first glance but maybe there is more to it than is
obvious and it should be safe as long as compile was tested on all supported
arches. The rest looks ok for the purpose of getting a new driver enabled.
-Stefan
Applied to Vivid master-next branch. Cheers, -- Luís