diff mbox

[U-Boot,1/4] exynos: Properly initialize host_caps in s5p_sdhci_core_init()

Message ID 1442791123-2664-2-git-send-email-tjakobi@math.uni-bielefeld.de
State Changes Requested
Delegated to: Minkyu Kang
Headers show

Commit Message

Tobias Jakobi Sept. 20, 2015, 11:18 p.m. UTC 
The sdhci_host struct is allocated in s5p_sdhci_init() but the
fields are not initialized.

Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
---
 drivers/mmc/s5p_sdhci.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Łukasz Majewski Sept. 23, 2015, 9:35 a.m. UTC | #1 
Hi Tobias,

> The sdhci_host struct is allocated in s5p_sdhci_init() but the
> fields are not initialized.
> 
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
>  drivers/mmc/s5p_sdhci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c
> index 4db51d6..e9c43a9 100644
> --- a/drivers/mmc/s5p_sdhci.c
> +++ b/drivers/mmc/s5p_sdhci.c
> @@ -76,6 +76,7 @@ static int s5p_sdhci_core_init(struct sdhci_host
> *host) host->set_control_reg = &s5p_sdhci_set_control_reg;
>  	host->set_clock = set_mmc_clk;
>  
> +	host->host_caps = 0;
>  	if (host->bus_width == 8)
>  		host->host_caps |= MMC_MODE_8BIT;
>  

Acked-by: Lukasz Majewski <l.majewski@samsung.com>
diff mbox

Patch

diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c
index 4db51d6..e9c43a9 100644
--- a/drivers/mmc/s5p_sdhci.c
+++ b/drivers/mmc/s5p_sdhci.c
@@ -76,6 +76,7 @@  static int s5p_sdhci_core_init(struct sdhci_host *host)
 	host->set_control_reg = &s5p_sdhci_set_control_reg;
 	host->set_clock = set_mmc_clk;
 
+	host->host_caps = 0;
 	if (host->bus_width == 8)
 		host->host_caps |= MMC_MODE_8BIT;