Patchwork [2/2] reformatted SS-5 and LX definitions

login
register
mail settings
Submitter Artyom Tarasenko
Date May 8, 2010, 2:10 p.m.
Message ID <1273327815-21408-2-git-send-email-atar4qemu@gmail.com>
Download mbox | patch
Permalink /patch/51966/
State New
Headers show

Comments

Artyom Tarasenko - May 8, 2010, 2:10 p.m.
---
 hw/sun4m.c |   66 ++++++++++++++++++++++++++++++------------------------------
 1 files changed, 33 insertions(+), 33 deletions(-)
Blue Swirl - May 9, 2010, 7:44 a.m.
On 5/8/10, Artyom Tarasenko <atar4qemu@googlemail.com> wrote:
> ---
>   hw/sun4m.c |   66 ++++++++++++++++++++++++++++++------------------------------
>   1 files changed, 33 insertions(+), 33 deletions(-)

In general, formatting changes cause git blame information loss so
those are not appreciated very much.

In this specific case, I don't see any need to reformat, because the
layout of SS-5 and LX definitions match the surrounding definitions.
One could argue that all definitions should be formatted to match the
longest field (.default_cpu_model), but I still think that it would
not gain much.

Patch

diff --git a/hw/sun4m.c b/hw/sun4m.c
index e31d039..7917f46 100644
--- a/hw/sun4m.c
+++ b/hw/sun4m.c
@@ -968,26 +968,26 @@  enum {
 static const struct sun4m_hwdef sun4m_hwdefs[] = {
     /* SS-5 */
     {
-        .iommu_base   = 0x10000000,
+        .iommu_base     = 0x10000000,
         .iommu_pad_base = 0x10004000,
         .iommu_pad_len  = 0x0fffb000,
-        .tcx_base     = 0x50000000,
-        .cs_base      = 0x6c000000,
-        .slavio_base  = 0x70000000,
-        .ms_kb_base   = 0x71000000,
-        .serial_base  = 0x71100000,
-        .nvram_base   = 0x71200000,
-        .fd_base      = 0x71400000,
-        .counter_base = 0x71d00000,
-        .intctl_base  = 0x71e00000,
-        .idreg_base   = 0x78000000,
-        .dma_base     = 0x78400000,
-        .esp_base     = 0x78800000,
-        .le_base      = 0x78c00000,
-        .apc_base     = 0x6a000000,
-        .afx_base     = 0x6e000000,
-        .aux1_base    = 0x71900000,
-        .aux2_base    = 0x71910000,
+        .tcx_base       = 0x50000000,
+        .cs_base        = 0x6c000000,
+        .slavio_base    = 0x70000000,
+        .ms_kb_base     = 0x71000000,
+        .serial_base    = 0x71100000,
+        .nvram_base     = 0x71200000,
+        .fd_base        = 0x71400000,
+        .counter_base   = 0x71d00000,
+        .intctl_base    = 0x71e00000,
+        .idreg_base     = 0x78000000,
+        .dma_base       = 0x78400000,
+        .esp_base       = 0x78800000,
+        .le_base        = 0x78c00000,
+        .apc_base       = 0x6a000000,
+        .afx_base       = 0x6e000000,
+        .aux1_base      = 0x71900000,
+        .aux2_base      = 0x71910000,
         .nvram_machine_id = 0x80,
         .machine_id = ss5_id,
         .iommu_version = 0x05000000,
@@ -1096,23 +1096,23 @@  static const struct sun4m_hwdef sun4m_hwdefs[] = {
     },
     /* LX */
     {
-        .iommu_base   = 0x10000000,
+        .iommu_base     = 0x10000000,
         .iommu_pad_base = 0x10004000,
         .iommu_pad_len  = 0x0fffb000,
-        .tcx_base     = 0x50000000,
-        .slavio_base  = 0x70000000,
-        .ms_kb_base   = 0x71000000,
-        .serial_base  = 0x71100000,
-        .nvram_base   = 0x71200000,
-        .fd_base      = 0x71400000,
-        .counter_base = 0x71d00000,
-        .intctl_base  = 0x71e00000,
-        .idreg_base   = 0x78000000,
-        .dma_base     = 0x78400000,
-        .esp_base     = 0x78800000,
-        .le_base      = 0x78c00000,
-        .aux1_base    = 0x71900000,
-        .aux2_base    = 0x71910000,
+        .tcx_base       = 0x50000000,
+        .slavio_base    = 0x70000000,
+        .ms_kb_base     = 0x71000000,
+        .serial_base    = 0x71100000,
+        .nvram_base     = 0x71200000,
+        .fd_base        = 0x71400000,
+        .counter_base   = 0x71d00000,
+        .intctl_base    = 0x71e00000,
+        .idreg_base     = 0x78000000,
+        .dma_base       = 0x78400000,
+        .esp_base       = 0x78800000,
+        .le_base        = 0x78c00000,
+        .aux1_base      = 0x71900000,
+        .aux2_base      = 0x71910000,
         .nvram_machine_id = 0x80,
         .machine_id = lx_id,
         .iommu_version = 0x04000000,