| Message ID | 1442606151-50429-5-git-send-email-sfeldma@gmail.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
Fri, Sep 18, 2015 at 09:55:48PM CEST, sfeldma@gmail.com wrote: >From: Scott Feldman <sfeldma@gmail.com> > >Signed-off-by: Scott Feldman <sfeldma@gmail.com> >--- > include/linux/if_bridge.h | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/include/linux/if_bridge.h b/include/linux/if_bridge.h >index dad8b00..6cc6dbc 100644 >--- a/include/linux/if_bridge.h >+++ b/include/linux/if_bridge.h >@@ -46,6 +46,10 @@ struct br_ip_list { > #define BR_LEARNING_SYNC BIT(9) > #define BR_PROXYARP_WIFI BIT(10) > >+/* values as per ieee8021QBridgeFdbAgingTime */ >+#define BR_MIN_AGEING_TIME (10 * HZ) >+#define BR_MAX_AGEING_TIME (1000000 * HZ) I think that a bridge patch checking against these values should be introduced along with these values, in the same patchset -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Sep 18, 2015 at 11:45 PM, Jiri Pirko <jiri@resnulli.us> wrote: > Fri, Sep 18, 2015 at 09:55:48PM CEST, sfeldma@gmail.com wrote: >>From: Scott Feldman <sfeldma@gmail.com> >> >>Signed-off-by: Scott Feldman <sfeldma@gmail.com> >>--- >> include/linux/if_bridge.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> >>diff --git a/include/linux/if_bridge.h b/include/linux/if_bridge.h >>index dad8b00..6cc6dbc 100644 >>--- a/include/linux/if_bridge.h >>+++ b/include/linux/if_bridge.h >>@@ -46,6 +46,10 @@ struct br_ip_list { >> #define BR_LEARNING_SYNC BIT(9) >> #define BR_PROXYARP_WIFI BIT(10) >> >>+/* values as per ieee8021QBridgeFdbAgingTime */ >>+#define BR_MIN_AGEING_TIME (10 * HZ) >>+#define BR_MAX_AGEING_TIME (1000000 * HZ) > > I think that a bridge patch checking against these values should be > introduced along with these values, in the same patchset I need the MIN value for this patchset in rocker's ageing timer, so it's introduced here. MIN/MAX will be used again in follow-on patch Prem is going to send to range check user input. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: Scott Feldman [mailto:sfeldma@gmail.com] > Sent: Saturday, September 19, 2015 10:51 PM > To: Jiri Pirko > Cc: Netdev; Siva Mannem; Premkumar Jonnala; stephen@networkplumber.org; > Roopa Prabhu; andrew@lunn.ch; Florian Fainelli; Vivien Didelot > Subject: Re: [PATCH net-next 4/7] bridge: define some min/max ageing time > constants we'll use next > > On Fri, Sep 18, 2015 at 11:45 PM, Jiri Pirko <jiri@resnulli.us> wrote: > > Fri, Sep 18, 2015 at 09:55:48PM CEST, sfeldma@gmail.com wrote: > >>From: Scott Feldman <sfeldma@gmail.com> > >> > >>Signed-off-by: Scott Feldman <sfeldma@gmail.com> > >>--- > >> include/linux/if_bridge.h | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >>diff --git a/include/linux/if_bridge.h b/include/linux/if_bridge.h > >>index dad8b00..6cc6dbc 100644 > >>--- a/include/linux/if_bridge.h > >>+++ b/include/linux/if_bridge.h > >>@@ -46,6 +46,10 @@ struct br_ip_list { > >> #define BR_LEARNING_SYNC BIT(9) > >> #define BR_PROXYARP_WIFI BIT(10) > >> > >>+/* values as per ieee8021QBridgeFdbAgingTime */ > >>+#define BR_MIN_AGEING_TIME (10 * HZ) > >>+#define BR_MAX_AGEING_TIME (1000000 * HZ) > > > > I think that a bridge patch checking against these values should be > > introduced along with these values, in the same patchset > > I need the MIN value for this patchset in rocker's ageing timer, so > it's introduced here. MIN/MAX will be used again in follow-on patch > Prem is going to send to range check user input. Ack that. I will add those checks as part of the patch for iproute2. -Prem
diff --git a/include/linux/if_bridge.h b/include/linux/if_bridge.h index dad8b00..6cc6dbc 100644 --- a/include/linux/if_bridge.h +++ b/include/linux/if_bridge.h @@ -46,6 +46,10 @@ struct br_ip_list { #define BR_LEARNING_SYNC BIT(9) #define BR_PROXYARP_WIFI BIT(10) +/* values as per ieee8021QBridgeFdbAgingTime */ +#define BR_MIN_AGEING_TIME (10 * HZ) +#define BR_MAX_AGEING_TIME (1000000 * HZ) + extern void brioctl_set(int (*ioctl_hook)(struct net *, unsigned int, void __user *)); typedef int br_should_route_hook_t(struct sk_buff *skb);