| Message ID | 1442590077-29816-1-git-send-email-grimaldi.ivan@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
Hi, You've sent that series so many times that I'm not sure which one I should look at... Also, please include a changelog when submitting a new version of a patch. On 18/09/2015 at 17:27:56 +0200, Ivan Grimaldi wrote : > spi_write_then_read puts in rx_buf the received data starting from > the first byte of the rx_buf > > Signed-off-by: Ivan Grimaldi <grimaldi.ivan@gmail.com> > --- > drivers/rtc/rtc-ds1390.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-ds1390.c b/drivers/rtc/rtc-ds1390.c > index e67bfcb..a4303b4 100644 > --- a/drivers/rtc/rtc-ds1390.c > +++ b/drivers/rtc/rtc-ds1390.c > @@ -62,7 +62,7 @@ static int ds1390_get_reg(struct device *dev, unsigned char address, > if (status != 0) > return status; > > - *data = chip->txrx_buf[1]; > + *data = chip->txrx_buf[0]; > > return 0; > } > -- > 2.5.2 > > -- > -- > You received this message because you are subscribed to "rtc-linux". > Membership options at http://groups.google.com/group/rtc-linux . > Please read http://groups.google.com/group/rtc-linux/web/checklist > before submitting a driver. > --- > You received this message because you are subscribed to the Google Groups "rtc-linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout.
I'm sorry, but I had trouble with my client behind the corporate proxy. The correct version of the patches are version 3; if you have problems with them, I can resend to you (I promise this time I will send it only once :-)). Next time I add also the changelog. Ivan 2015-09-19 0:01 GMT+02:00 Alexandre Belloni < alexandre.belloni@free-electrons.com>: > Hi, > > You've sent that series so many times that I'm not sure which one I > should look at... > > Also, please include a changelog when submitting a new version of a > patch. > > On 18/09/2015 at 17:27:56 +0200, Ivan Grimaldi wrote : > > spi_write_then_read puts in rx_buf the received data starting from > > the first byte of the rx_buf > > > > Signed-off-by: Ivan Grimaldi <grimaldi.ivan@gmail.com> > > --- > > drivers/rtc/rtc-ds1390.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/rtc/rtc-ds1390.c b/drivers/rtc/rtc-ds1390.c > > index e67bfcb..a4303b4 100644 > > --- a/drivers/rtc/rtc-ds1390.c > > +++ b/drivers/rtc/rtc-ds1390.c > > @@ -62,7 +62,7 @@ static int ds1390_get_reg(struct device *dev, unsigned > char address, > > if (status != 0) > > return status; > > > > - *data = chip->txrx_buf[1]; > > + *data = chip->txrx_buf[0]; > > > > return 0; > > } > > -- > > 2.5.2 > > > > -- > > -- > > You received this message because you are subscribed to "rtc-linux". > > Membership options at http://groups.google.com/group/rtc-linux . > > Please read http://groups.google.com/group/rtc-linux/web/checklist > > before submitting a driver. > > --- > > You received this message because you are subscribed to the Google > Groups "rtc-linux" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to rtc-linux+unsubscribe@googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. > > -- > Alexandre Belloni, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com >
diff --git a/drivers/rtc/rtc-ds1390.c b/drivers/rtc/rtc-ds1390.c index e67bfcb..a4303b4 100644 --- a/drivers/rtc/rtc-ds1390.c +++ b/drivers/rtc/rtc-ds1390.c @@ -62,7 +62,7 @@ static int ds1390_get_reg(struct device *dev, unsigned char address, if (status != 0) return status; - *data = chip->txrx_buf[1]; + *data = chip->txrx_buf[0]; return 0; }
spi_write_then_read puts in rx_buf the received data starting from the first byte of the rx_buf Signed-off-by: Ivan Grimaldi <grimaldi.ivan@gmail.com> --- drivers/rtc/rtc-ds1390.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)