diff mbox

[v5,08/38] block/raw_bsd: Drop raw_is_inserted()

Message ID 1442589793-7105-9-git-send-email-mreitz@redhat.com
State New
Headers show

Commit Message

Max Reitz Sept. 18, 2015, 3:22 p.m. UTC
With the new automatically-recursive implementation of
bdrv_is_inserted() checking by default whether all the children of a BDS
are inserted, we can drop raw's own implementation.

Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 block/raw_bsd.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Eric Blake Sept. 18, 2015, 4:20 p.m. UTC | #1
On 09/18/2015 09:22 AM, Max Reitz wrote:
> With the new automatically-recursive implementation of
> bdrv_is_inserted() checking by default whether all the children of a BDS
> are inserted, we can drop raw's own implementation.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  block/raw_bsd.c | 6 ------
>  1 file changed, 6 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>
Alberto Garcia Sept. 29, 2015, 10:47 a.m. UTC | #2
On Fri 18 Sep 2015 05:22:43 PM CEST, Max Reitz <mreitz@redhat.com> wrote:
> With the new automatically-recursive implementation of
> bdrv_is_inserted() checking by default whether all the children of a BDS
> are inserted, we can drop raw's own implementation.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto
diff mbox

Patch

diff --git a/block/raw_bsd.c b/block/raw_bsd.c
index d718583..891a1fa 100644
--- a/block/raw_bsd.c
+++ b/block/raw_bsd.c
@@ -154,11 +154,6 @@  static int raw_truncate(BlockDriverState *bs, int64_t offset)
     return bdrv_truncate(bs->file, offset);
 }
 
-static bool raw_is_inserted(BlockDriverState *bs)
-{
-    return bdrv_is_inserted(bs->file);
-}
-
 static int raw_media_changed(BlockDriverState *bs)
 {
     return bdrv_media_changed(bs->file);
@@ -264,7 +259,6 @@  BlockDriver bdrv_raw = {
     .bdrv_refresh_limits  = &raw_refresh_limits,
     .bdrv_probe_blocksizes = &raw_probe_blocksizes,
     .bdrv_probe_geometry  = &raw_probe_geometry,
-    .bdrv_is_inserted     = &raw_is_inserted,
     .bdrv_media_changed   = &raw_media_changed,
     .bdrv_eject           = &raw_eject,
     .bdrv_lock_medium     = &raw_lock_medium,