Message ID | 9235D6609DB808459E95D78E17F2E43D55C688@CHN-SV-EXMX02.mchp-main.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
All 6 patches applied, thanks. But in the future, please provide an initial "[PATCH net 0/6]" posting which gives a top-level overview of what your patch series is doing. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks David, I'll add overview "[PATCH net 0/#]" next time. > -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: Friday, September 18, 2015 1:16 AM > To: Woojung Huh - C21699 > Cc: netdev@vger.kernel.org > Subject: Re: [PATCH net 1/6] lan78xx: Check device ready bit > (PMT_CTL_READY_) after reset the PHY > > > All 6 patches applied, thanks. > > But in the future, please provide an initial "[PATCH net 0/6]" posting which > gives a top-level overview of what your patch series is doing. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index a39518f..d0d8790 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -2002,7 +2002,7 @@ static int lan78xx_reset(struct lan78xx_net *dev) netdev_warn(dev->net, "timeout waiting for PHY Reset"); return -EIO; } - } while (buf & PMT_CTL_PHY_RST_); + } while ((buf & PMT_CTL_PHY_RST_) || !(buf & PMT_CTL_READY_)); lan78xx_mii_init(dev);
Check device ready bit (PMT_CTL_READY_) after reset the PHY. Device may not be ready even if PHY_RST_ is cleared depends on configuration. Signed-off-by: Woojung Huh <woojung.huh@microchip.com> --- drivers/net/usb/lan78xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)