pinctrl: sirf: Fix module autoloading for OF
diff mbox

Message ID 1442389425-27846-1-git-send-email-javier@osg.samsung.com
State New
Headers show

Commit Message

Javier Martinez Canillas Sept. 16, 2015, 7:43 a.m. UTC
Drivers needs to export the OF id table and this be built into
the module or udev won't have the necessary information to auto
load the driver module when the device is registered by OF.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 drivers/pinctrl/sirf/pinctrl-atlas7.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Javier Martinez Canillas Sept. 16, 2015, 7:51 a.m. UTC | #1
Hello,

On 09/16/2015 09:43 AM, Javier Martinez Canillas wrote:
> Drivers needs to export the OF id table and this be built into
> the module or udev won't have the necessary information to auto
> load the driver module when the device is registered by OF.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 

Just found out that PINCTRL_SIRF is a boolean Kconfig symbol and not
a tristate one so it can't be built as a module. Sorry for the noise.

Best regards,
Linus Walleij Oct. 2, 2015, 10:15 a.m. UTC | #2
On Wed, Sep 16, 2015 at 12:51 AM, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> On 09/16/2015 09:43 AM, Javier Martinez Canillas wrote:
>> Drivers needs to export the OF id table and this be built into
>> the module or udev won't have the necessary information to auto
>> load the driver module when the device is registered by OF.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>
> Just found out that PINCTRL_SIRF is a boolean Kconfig symbol and not
> a tristate one so it can't be built as a module. Sorry for the noise.

OK dropping this.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/pinctrl/sirf/pinctrl-atlas7.c b/drivers/pinctrl/sirf/pinctrl-atlas7.c
index 9df0c5f25824..dd6c9b7ac1ad 100644
--- a/drivers/pinctrl/sirf/pinctrl-atlas7.c
+++ b/drivers/pinctrl/sirf/pinctrl-atlas7.c
@@ -4304,6 +4304,7 @@  static const struct of_device_id atlas7_pinmux_ids[] = {
 	{ .compatible = "sirf,atlas7-ioc",},
 	{},
 };
+MODULE_DEVICE_TABLE(of, atlas7_pinmux_ids);
 
 static struct platform_driver atlas7_pinmux_driver = {
 	.driver = {
@@ -4702,6 +4703,7 @@  static const struct of_device_id atlas7_gpio_ids[] = {
 	{ .compatible = "sirf,atlas7-gpio", },
 	{},
 };
+MODULE_DEVICE_TABLE(of, atlas7_gpio_ids);
 
 static int atlas7_gpio_probe(struct platform_device *pdev)
 {