diff mbox

[v3,30/46] ivshmem: reset mask on device reset

Message ID 1442333283-13119-31-git-send-email-marcandre.lureau@redhat.com
State New
Headers show

Commit Message

Marc-André Lureau Sept. 15, 2015, 4:07 p.m. UTC 
From: Marc-André Lureau <marcandre.lureau@redhat.com>

The interrupt mask is a state value, it should be reset, like the value.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 hw/misc/ivshmem.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Claudio Fontana Sept. 16, 2015, 12:15 p.m. UTC | #1 
On 15.09.2015 18:07, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> The interrupt mask is a state value, it should be reset, like the value.

probably you wanted to say "it should be reset, like the interrupt status".

> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  hw/misc/ivshmem.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index 63e4c4f..6c0a829 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -617,6 +617,7 @@ static void ivshmem_reset(DeviceState *d)
>      IVShmemState *s = IVSHMEM(d);
>  
>      s->intrstatus = 0;
> +    s->intrmask = 0;
>      ivshmem_use_msix(s);
>  }
>  
> 

Ciao

CLaudio
Marc-André Lureau Sept. 23, 2015, 10:48 a.m. UTC | #2 
Hi

On Wed, Sep 16, 2015 at 2:15 PM, Claudio Fontana
<claudio.fontana@huawei.com> wrote:
> probably you wanted to say "it should be reset, like the interrupt status".


yes, thanks
diff mbox

Patch

diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 63e4c4f..6c0a829 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -617,6 +617,7 @@  static void ivshmem_reset(DeviceState *d)
     IVShmemState *s = IVSHMEM(d);
 
     s->intrstatus = 0;
+    s->intrmask = 0;
     ivshmem_use_msix(s);
 }