| Message ID | 20150915154552.GA3060@goodgumbo.baconseed.org |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
On Tue, Sep 15, 2015 at 05:45:52PM +0200, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> > --- > > Hello, > > This patch adds the missing MODULE_DEVICE_TABLE() for OF to export > that information so modules have the correct aliases built-in and > autoloading works correctly. > > A longer explanation by Javier Canillas can be found here: > https://lkml.org/lkml/2015/7/30/519 Can you please include that in the patch description? Or at least add Link: tag? Also, should this be routed through -stable? Thanks.
On Tue, Sep 15, 2015 at 11:52:10AM -0400, Tejun Heo wrote: > On Tue, Sep 15, 2015 at 05:45:52PM +0200, Luis de Bethencourt wrote: > > This platform driver has a OF device ID table but the OF module > > alias information is not created so module autoloading won't work. > > > > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> > > --- > > > > Hello, > > > > This patch adds the missing MODULE_DEVICE_TABLE() for OF to export > > that information so modules have the correct aliases built-in and > > autoloading works correctly. > > > > A longer explanation by Javier Canillas can be found here: > > https://lkml.org/lkml/2015/7/30/519 > > Can you please include that in the patch description? Or at least add > Link: tag? Also, should this be routed through -stable? > > Thanks. > > -- > tejun Tejun, Sent a second version. Thank you very much for the review, Luis -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c index a02f76f..aba634e 100644 --- a/drivers/ata/pata_macio.c +++ b/drivers/ata/pata_macio.c @@ -1344,6 +1344,7 @@ static struct of_device_id pata_macio_match[] = }, {}, }; +MODULE_DEVICE_TABLE(of, pata_macio_match); static struct macio_driver pata_macio_driver = {
This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> --- Hello, This patch adds the missing MODULE_DEVICE_TABLE() for OF to export that information so modules have the correct aliases built-in and autoloading works correctly. A longer explanation by Javier Canillas can be found here: https://lkml.org/lkml/2015/7/30/519 Thanks, Luis drivers/ata/pata_macio.c | 1 + 1 file changed, 1 insertion(+)