Patchwork UBI: Remaining typos and comments cleanups

login
register
mail settings
Submitter Shinya Kuribayashi
Date May 6, 2010, 3:42 a.m.
Message ID <4BE23A8D.7040106@renesas.com>
Download mbox | patch
Permalink /patch/51778/
State New
Headers show

Comments

Shinya Kuribayashi - May 6, 2010, 3:42 a.m.
Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
---
  drivers/mtd/ubi/io.c   |    2 +-
  drivers/mtd/ubi/vtbl.c |    4 ++--
  2 files changed, 3 insertions(+), 3 deletions(-)
Shinya Kuribayashi - May 6, 2010, 9:26 a.m.
Artem-san,

On 5/6/2010 12:42 PM, Shinya Kuribayashi wrote:
> diff --git a/drivers/mtd/ubi/io.c b/drivers/mtd/ubi/io.c
> index 016ec13..cd0bf57 100644
> --- a/drivers/mtd/ubi/io.c
> +++ b/drivers/mtd/ubi/io.c
> @@ -64,7 +64,7 @@
>   * device, e.g., make @ubi->min_io_size = 512 in the example above?
>   *
>   * A: because when writing a sub-page, MTD still writes a full 2K page but the
> - * bytes which are no relevant to the sub-page are 0xFF. So, basically, writing
> + * bytes which are not relevant to the sub-page are 0xFF. So, basically, writing
>   * 4x512 sub-pages is 4 times slower than writing one 2KiB NAND page.  Thus, we
>   * prefer to use sub-pages only for EV and VID headers.
>   *                                 ^^^^

Looking at the last line, I think above 'EV' is a typo of 'EC', right?
I'll incorporate it in the next submission,
Artem Bityutskiy - May 6, 2010, 10:19 a.m.
On Thu, 2010-05-06 at 18:26 +0900, Shinya Kuribayashi wrote:
> Artem-san,
> 
> On 5/6/2010 12:42 PM, Shinya Kuribayashi wrote:
> > diff --git a/drivers/mtd/ubi/io.c b/drivers/mtd/ubi/io.c
> > index 016ec13..cd0bf57 100644
> > --- a/drivers/mtd/ubi/io.c
> > +++ b/drivers/mtd/ubi/io.c
> > @@ -64,7 +64,7 @@
> >   * device, e.g., make @ubi->min_io_size = 512 in the example above?
> >   *
> >   * A: because when writing a sub-page, MTD still writes a full 2K page but the
> > - * bytes which are no relevant to the sub-page are 0xFF. So, basically, writing
> > + * bytes which are not relevant to the sub-page are 0xFF. So, basically, writing
> >   * 4x512 sub-pages is 4 times slower than writing one 2KiB NAND page.  Thus, we
> >   * prefer to use sub-pages only for EV and VID headers.
> >   *                                 ^^^^
> 
> Looking at the last line, I think above 'EV' is a typo of 'EC', right?
> I'll incorporate it in the next submission,

Right

Patch

diff --git a/drivers/mtd/ubi/io.c b/drivers/mtd/ubi/io.c
index 016ec13..cd0bf57 100644
--- a/drivers/mtd/ubi/io.c
+++ b/drivers/mtd/ubi/io.c
@@ -64,7 +64,7 @@ 
   * device, e.g., make @ubi->min_io_size = 512 in the example above?
   *
   * A: because when writing a sub-page, MTD still writes a full 2K page but the
- * bytes which are no relevant to the sub-page are 0xFF. So, basically, writing
+ * bytes which are not relevant to the sub-page are 0xFF. So, basically, writing
   * 4x512 sub-pages is 4 times slower than writing one 2KiB NAND page. Thus, we
   * prefer to use sub-pages only for EV and VID headers.
   *
diff --git a/drivers/mtd/ubi/vtbl.c b/drivers/mtd/ubi/vtbl.c
index cd90ff3..14c10be 100644
--- a/drivers/mtd/ubi/vtbl.c
+++ b/drivers/mtd/ubi/vtbl.c
@@ -414,7 +414,7 @@  static struct ubi_vtbl_record *process_lvol(struct ubi_device *ubi,
  	 * 0 contains more recent information.
  	 *
  	 * So the plan is to first check LEB 0. Then
-	 * a. if LEB 0 is OK, it must be containing the most resent data; then
+	 * a. if LEB 0 is OK, it must be containing the most recent data; then
  	 *    we compare it with LEB 1, and if they are different, we copy LEB
  	 *    0 to LEB 1;
  	 * b. if LEB 0 is corrupted, but LEB 1 has to be OK, and we copy LEB 1
@@ -848,7 +848,7 @@  int ubi_read_volume_table(struct ubi_device *ubi, struct ubi_scan_info *si)
  		goto out_free;
  
  	/*
-	 * Get sure that the scanning information is consistent to the
+	 * Make sure that the scanning information is consistent to the
  	 * information stored in the volume table.
  	 */
  	err = check_scanning_info(ubi, si);