Patchwork Format string bug in drivers/of/of_i2c.c

login
register
mail settings
Submitter Jon Smirl
Date Oct. 21, 2008, 2:57 a.m.
Message ID <9e4733910810201957r59433e74xbdeef6a035f3f9ee@mail.gmail.com>
Download mbox | patch
Permalink /patch/5177/
State Accepted
Headers show

Comments

Jon Smirl - Oct. 21, 2008, 2:57 a.m.
Format string bug.  Not exploitable, as this is only writable by root,
but worth fixing all the same.

See 326f6a5c9c9e1a62aec37bdc0c3f8d53adabe77b

Signed-off-by: Jon Smirl <jonsmirl@gmail.com>
---
 drivers/of/of_i2c.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c
index 6a98dc8..24bbef7 100644
--- a/drivers/of/of_i2c.c
+++ b/drivers/of/of_i2c.c
@@ -41,7 +41,7 @@  void of_register_i2c_devices(struct i2c_adapter *adap,

 		info.addr = *addr;

-		request_module(info.type);
+		request_module("%s", info.type);

 		result = i2c_new_device(adap, &info);
 		if (result == NULL) {