| Message ID | 1442221736-16377-3-git-send-email-Peng.Fan@freescale.com |
|---|---|
| State | Superseded |
| Delegated to: | Stefano Babic |
| Headers | show |
Hi Peng, On Mon, Sep 14, 2015 at 6:08 AM, Peng Fan <Peng.Fan@freescale.com> wrote: > Since i.MX7D does not support warm reset, so boot_mode_apply > actually will not work. Also we use outer pmic reset and drop > internal reset signal, so drop boot mode code for 7dsabresd board. Booting via bmode is working fine here. Regards, Fabio Estevam
Hi Fabio, On Mon, Sep 14, 2015 at 03:09:24PM -0300, Fabio Estevam wrote: >Hi Peng, > >On Mon, Sep 14, 2015 at 6:08 AM, Peng Fan <Peng.Fan@freescale.com> wrote: >> Since i.MX7D does not support warm reset, so boot_mode_apply >> actually will not work. Also we use outer pmic reset and drop >> internal reset signal, so drop boot mode code for 7dsabresd board. > >Booting via bmode is working fine here. If boot from sd1, bmode sd1 work well. If boot from qspi1, bmode qspi work well. This is expected. If boot from qspi, but we use 'bmode sd1', this will not work. The reason that introduce bmode command is to boot from different media, but now we use wdog signal to trigger pmic reset, which means the SoC will be powered off and powered on. There is no reason to keep bmode. This patch needs my previous wdog patch set. Regards, Peng. > >Regards, > >Fabio Estevam
Hi Peng, On Mon, Sep 14, 2015 at 9:31 PM, Peng Fan <b51431@freescale.com> wrote: > Hi Fabio, > On Mon, Sep 14, 2015 at 03:09:24PM -0300, Fabio Estevam wrote: >>Hi Peng, >> >>On Mon, Sep 14, 2015 at 6:08 AM, Peng Fan <Peng.Fan@freescale.com> wrote: >>> Since i.MX7D does not support warm reset, so boot_mode_apply >>> actually will not work. Also we use outer pmic reset and drop >>> internal reset signal, so drop boot mode code for 7dsabresd board. >> >>Booting via bmode is working fine here. > > If boot from sd1, bmode sd1 work well. If boot from qspi1, bmode qspi work well. > This is expected. If boot from qspi, but we use 'bmode sd1', this will not work. Understood. I only booted from sd1 and did 'bmode sd1'. Regards, Fabio Estevam
diff --git a/board/freescale/mx7dsabresd/mx7dsabresd.c b/board/freescale/mx7dsabresd/mx7dsabresd.c index 6d88573..2b14fb6 100644 --- a/board/freescale/mx7dsabresd/mx7dsabresd.c +++ b/board/freescale/mx7dsabresd/mx7dsabresd.c @@ -10,7 +10,6 @@ #include <asm/arch/sys_proto.h> #include <asm/gpio.h> #include <asm/imx-common/iomux-v3.h> -#include <asm/imx-common/boot_mode.h> #include <asm/io.h> #include <linux/sizes.h> #include <common.h> @@ -458,15 +457,6 @@ int board_init(void) return 0; } -#ifdef CONFIG_CMD_BMODE -static const struct boot_mode board_boot_modes[] = { - /* 4 bit bus width */ - {"sd1", MAKE_CFGVAL(0x10, 0x10, 0x00, 0x00)}, - {"emmc", MAKE_CFGVAL(0x10, 0x2a, 0x00, 0x00)}, - {NULL, 0}, -}; -#endif - #ifdef CONFIG_POWER #define I2C_PMIC 0 int power_init_board(void) @@ -501,10 +491,6 @@ int board_late_init(void) { struct wdog_regs *wdog = (struct wdog_regs *)WDOG1_BASE_ADDR; -#ifdef CONFIG_CMD_BMODE - add_board_boot_modes(board_boot_modes); -#endif - #ifdef CONFIG_ENV_IS_IN_MMC mmc_late_init(); #endif diff --git a/include/configs/mx7dsabresd.h b/include/configs/mx7dsabresd.h index ec6e0a6..8231c04 100644 --- a/include/configs/mx7dsabresd.h +++ b/include/configs/mx7dsabresd.h @@ -175,8 +175,6 @@ #define CONFIG_SYS_MMC_ENV_PART 0 /* user area */ #define CONFIG_MMCROOT "/dev/mmcblk0p2" /* USDHC1 */ -#define CONFIG_CMD_BMODE - /* USB Configs */ #define CONFIG_CMD_USB #define CONFIG_USB_EHCI
Since i.MX7D does not support warm reset, so boot_mode_apply actually will not work. Also we use outer pmic reset and drop internal reset signal, so drop boot mode code for 7dsabresd board. Signed-off-by: Peng Fan <Peng.Fan@freescale.com> Cc: Stefano Babic <sbabic@denx.de> Cc: Adrian Alonso <aalonso@freescale.com> --- board/freescale/mx7dsabresd/mx7dsabresd.c | 14 -------------- include/configs/mx7dsabresd.h | 2 -- 2 files changed, 16 deletions(-)