diff mbox

[3/5] lan78xx: Add PHYLIB and MICROCHIP_PHY as default config.

Message ID 9235D6609DB808459E95D78E17F2E43D557C4F@CHN-SV-EXMX02.mchp-main.com
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Woojung.Huh@microchip.com Sept. 10, 2015, 8:48 p.m. UTC
Add PHYLIB and MICROCHIP_PHY as default configuration for  lan78xx.

Signed-off-by: Woojung Huh <woojung.huh@microchip.com>
---
 drivers/net/usb/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Florian Fainelli Sept. 10, 2015, 9:46 p.m. UTC | #1
On 10/09/15 13:48, Woojung.Huh@microchip.com wrote:
> Add PHYLIB and MICROCHIP_PHY as default configuration for  lan78xx.

You would want to swap this patch and patch 2 to make sure that there is
no user-visible breakage in between.

> 
> Signed-off-by: Woojung Huh <woojung.huh@microchip.com>
> ---
>  drivers/net/usb/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
> index 1610b79..d9ca7aa 100644
> --- a/drivers/net/usb/Kconfig
> +++ b/drivers/net/usb/Kconfig
> @@ -109,6 +109,8 @@ config USB_RTL8152
>  config USB_LAN78XX
>  	tristate "Microchip LAN78XX Based USB Ethernet Adapters"
>  	select MII
> +	select PHYLIB
> +	select MICROCHIP_PHY
>  	help
>  	  This option adds support for Microchip LAN78XX based USB 2
>  	  & USB 3 10/100/1000 Ethernet adapters.
>
Woojung.Huh@microchip.com Sept. 10, 2015, 10:04 p.m. UTC | #2
Thanks.
Will repost as order you commented.

> -----Original Message-----

> From: Florian Fainelli [mailto:f.fainelli@gmail.com]

> Sent: Thursday, September 10, 2015 5:47 PM

> To: Woojung Huh - C21699; davem@davemloft.net

> Cc: netdev@vger.kernel.org

> Subject: Re: [PATCH 3/5] lan78xx: Add PHYLIB and MICROCHIP_PHY as

> default config.

> 

> On 10/09/15 13:48, Woojung.Huh@microchip.com wrote:

> > Add PHYLIB and MICROCHIP_PHY as default configuration for  lan78xx.

> 

> You would want to swap this patch and patch 2 to make sure that there is

> no user-visible breakage in between.

> 

> >

> > Signed-off-by: Woojung Huh <woojung.huh@microchip.com>

> > ---

> >  drivers/net/usb/Kconfig | 2 ++

> >  1 file changed, 2 insertions(+)

> >

> > diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig

> > index 1610b79..d9ca7aa 100644

> > --- a/drivers/net/usb/Kconfig

> > +++ b/drivers/net/usb/Kconfig

> > @@ -109,6 +109,8 @@ config USB_RTL8152

> >  config USB_LAN78XX

> >  	tristate "Microchip LAN78XX Based USB Ethernet Adapters"

> >  	select MII

> > +	select PHYLIB

> > +	select MICROCHIP_PHY

> >  	help

> >  	  This option adds support for Microchip LAN78XX based USB 2

> >  	  & USB 3 10/100/1000 Ethernet adapters.

> >

> 

> 

> --

> Florian
diff mbox

Patch

diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index 1610b79..d9ca7aa 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -109,6 +109,8 @@  config USB_RTL8152
 config USB_LAN78XX
 	tristate "Microchip LAN78XX Based USB Ethernet Adapters"
 	select MII
+	select PHYLIB
+	select MICROCHIP_PHY
 	help
 	  This option adds support for Microchip LAN78XX based USB 2
 	  & USB 3 10/100/1000 Ethernet adapters.