From patchwork Tue May 4 16:16:34 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: FEC: Fix kernel panic in fec_set_mac_address. Date: Tue, 04 May 2010 06:16:34 -0000 From: Tim Gardner X-Patchwork-Id: 51630 Message-Id: <4BE04862.2030503@canonical.com> To: Bryan Wu Cc: Kernel team list Bryan - this looks like a bonafide bug (forwarded from LKML) -------- Original Message -------- Subject: [PATCH] FEC: Fix kernel panic in fec_set_mac_address. Date: Tue, 04 May 2010 16:16:30 +0200 From: Mattias Walstrom To: netdev@vger.kernel.org Fix memory corruption that sometimes result in kernel panic. Signed-off-by: Mattias Walström fec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/fec.c b/drivers/net/fec.c index 9f98c1c..9b4e8f7 100644 --- a/drivers/net/fec.c +++ b/drivers/net/fec.c @@ -1653,7 +1653,7 @@ fec_set_mac_address(struct net_device *dev, void *p) (dev->dev_addr[1] << 16) | (dev->dev_addr[0] << 24), fep->hwp + FEC_ADDR_LOW); writel((dev->dev_addr[5] << 16) | (dev->dev_addr[4] << 24), - fep + FEC_ADDR_HIGH); + fep->hwp + FEC_ADDR_HIGH); return 0; }