From patchwork Tue May 4 12:45:21 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Tosatti X-Patchwork-Id: 51611 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E60F3B7D27 for ; Wed, 5 May 2010 00:28:34 +1000 (EST) Received: from localhost ([127.0.0.1]:47261 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9IZC-000505-AL for incoming@patchwork.ozlabs.org; Tue, 04 May 2010 09:53:42 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O9IVY-0001yv-7X for qemu-devel@nongnu.org; Tue, 04 May 2010 09:49:56 -0400 Received: from [140.186.70.92] (port=53016 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9IVW-0001xa-R0 for qemu-devel@nongnu.org; Tue, 04 May 2010 09:49:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O9IVU-00044L-Ky for qemu-devel@nongnu.org; Tue, 04 May 2010 09:49:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10534) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9IVU-00043w-Ag for qemu-devel@nongnu.org; Tue, 04 May 2010 09:49:52 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o44DnpGO030350 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 4 May 2010 09:49:51 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o44DbLmi000317; Tue, 4 May 2010 09:49:51 -0400 Received: from amt.cnet (vpn2-10-150.ams2.redhat.com [10.36.10.150]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o44CwSX5023281; Tue, 4 May 2010 09:00:13 -0400 Received: from amt.cnet (amt.cnet [127.0.0.1]) by amt.cnet (Postfix) with ESMTP id 782AD68A9C3; Tue, 4 May 2010 09:54:54 -0300 (BRT) Received: (from marcelo@localhost) by amt.cnet (8.14.3/8.14.3/Submit) id o44Csqww016561; Tue, 4 May 2010 09:54:52 -0300 Message-Id: <20100504124634.283705416@redhat.com> User-Agent: quilt/0.47-1 Date: Tue, 04 May 2010 09:45:21 -0300 From: Marcelo Tosatti To: kvm@vger.kernel.org, qemu-devel@nongnu.org References: <20100504124518.979470863@redhat.com> Content-Disposition: inline; filename=ipi-on-cpu-kick X-Scanned-By: MIMEDefang 2.67 on 10.5.11.16 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: Marcelo Tosatti Subject: [Qemu-devel] [patch uq/master 3/9] standardize on qemu_cpu_kick for signalling cpu thread(s) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Marcelo Tosatti Index: qemu/cpus.c =================================================================== --- qemu.orig/cpus.c +++ qemu/cpus.c @@ -454,8 +454,7 @@ void qemu_cpu_kick(void *_env) { CPUState *env = _env; qemu_cond_broadcast(env->halt_cond); - if (kvm_enabled()) - qemu_thread_signal(env->thread, SIG_IPI); + qemu_thread_signal(env->thread, SIG_IPI); } int qemu_cpu_self(void *_env) @@ -583,7 +582,6 @@ void pause_all_vcpus(void) while (penv) { penv->stop = 1; - qemu_thread_signal(penv->thread, SIG_IPI); qemu_cpu_kick(penv); penv = (CPUState *)penv->next_cpu; } @@ -592,7 +590,7 @@ void pause_all_vcpus(void) qemu_cond_timedwait(&qemu_pause_cond, &qemu_global_mutex, 100); penv = first_cpu; while (penv) { - qemu_thread_signal(penv->thread, SIG_IPI); + qemu_cpu_kick(penv); penv = (CPUState *)penv->next_cpu; } } @@ -605,7 +603,6 @@ void resume_all_vcpus(void) while (penv) { penv->stop = 0; penv->stopped = 0; - qemu_thread_signal(penv->thread, SIG_IPI); qemu_cpu_kick(penv); penv = (CPUState *)penv->next_cpu; }