From patchwork Tue Oct 21 05:44:02 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: roel kluin X-Patchwork-Id: 5161 X-Patchwork-Delegate: jgarzik@pobox.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id BFAD2DDE04 for ; Tue, 21 Oct 2008 10:44:16 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752031AbYJTXoL (ORCPT ); Mon, 20 Oct 2008 19:44:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751910AbYJTXoJ (ORCPT ); Mon, 20 Oct 2008 19:44:09 -0400 Received: from nf-out-0910.google.com ([64.233.182.185]:29186 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751822AbYJTXoI (ORCPT ); Mon, 20 Oct 2008 19:44:08 -0400 Received: by nf-out-0910.google.com with SMTP id d3so1055380nfc.21 for ; Mon, 20 Oct 2008 16:44:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:content-type :content-transfer-encoding; bh=FtsVCqps24vpGkfl/MVStkvMk8+KwdhrWGcA/mVRDek=; b=iGk3lfYoNU2AMoV76iQoI6mCKvsPV8UQyG6sKg3/Jmdx8xEkTkLHYZlS/KLNBPVHmu WdDiU2+Ux1XXtlt0y0POrdls6+dHohFREGFK8b41e7UyCy1BWJfIMfEatr1Oi055b7Sy sEUuPjjYMmoqFxbgh80AryPeIYttbuj/e5bpU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; b=p5942YBi+YZFCWUdqx3kcJGqFCoTeQYizJDH8680V7vyXiGUPW0Q1kPZ6RGP152mA7 SKU/AQSEGg4m+cGTyWtS6FlBr0WxdE0dJmqXrzcHJQclpTpjsKLCfHLALLCbp2LqQbNh nL+EOEpwq0HSkfoTGFivW2mkCCSOTrW7g35rM= Received: by 10.210.27.20 with SMTP id a20mr9484242eba.115.1224546245255; Mon, 20 Oct 2008 16:44:05 -0700 (PDT) Received: from ?192.168.1.117? (d133062.upc-d.chello.nl [213.46.133.62]) by mx.google.com with ESMTPS id z40sm6994930ikz.7.2008.10.20.16.44.04 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 20 Oct 2008 16:44:04 -0700 (PDT) Message-ID: <48FD6C22.8030607@gmail.com> Date: Tue, 21 Oct 2008 01:44:02 -0400 From: roel kluin User-Agent: Mozilla-Thunderbird 2.0.0.9 (X11/20080110) MIME-Version: 1.0 To: ben-linux@fluff.org CC: netdev@vger.kernel.org Subject: [PATCH] AX88796: ax_probe() fix irq assignment Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org dev->irq is unsigned Signed-off-by: Roel Kluin --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c index 4207d6e..9a314d8 100644 --- a/drivers/net/ax88796.c +++ b/drivers/net/ax88796.c @@ -838,12 +838,12 @@ static int ax_probe(struct platform_device *pdev) /* find the platform resources */ - dev->irq = platform_get_irq(pdev, 0); - if (dev->irq < 0) { + ret = platform_get_irq(pdev, 0); + if (ret < 0) { dev_err(&pdev->dev, "no IRQ specified\n"); - ret = -ENXIO; goto exit_mem; } + dev->irq = ret; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (res == NULL) {