Patchwork AX88796: ax_probe() fix irq assignment

login
register
mail settings
Submitter roel kluin
Date Oct. 21, 2008, 5:44 a.m.
Message ID <48FD6C22.8030607@gmail.com>
Download mbox | patch
Permalink /patch/5161/
State Accepted
Delegated to: Jeff Garzik
Headers show

Comments

Jeff Garzik - Oct. 21, 2008, 5:15 a.m.
roel kluin wrote:
> dev->irq is unsigned
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c
> index 4207d6e..9a314d8 100644
> --- a/drivers/net/ax88796.c
> +++ b/drivers/net/ax88796.c
> @@ -838,12 +838,12 @@ static int ax_probe(struct platform_device *pdev)
>  
>  	/* find the platform resources */
>  
> -	dev->irq  = platform_get_irq(pdev, 0);
> -	if (dev->irq < 0) {
> +	ret  = platform_get_irq(pdev, 0);
> +	if (ret < 0) {
>  		dev_err(&pdev->dev, "no IRQ specified\n");
> -		ret = -ENXIO;
>  		goto exit_mem;
>  	}
> +	dev->irq = ret;

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
roel kluin - Oct. 21, 2008, 5:44 a.m.
dev->irq is unsigned

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c
index 4207d6e..9a314d8 100644
--- a/drivers/net/ax88796.c
+++ b/drivers/net/ax88796.c
@@ -838,12 +838,12 @@  static int ax_probe(struct platform_device *pdev)
 
 	/* find the platform resources */
 
-	dev->irq  = platform_get_irq(pdev, 0);
-	if (dev->irq < 0) {
+	ret  = platform_get_irq(pdev, 0);
+	if (ret < 0) {
 		dev_err(&pdev->dev, "no IRQ specified\n");
-		ret = -ENXIO;
 		goto exit_mem;
 	}
+	dev->irq = ret;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (res == NULL) {