| Message ID | 1441790938-29042-6-git-send-email-kraxel@redhat.com |
|---|---|
| State | New |
| Headers | show |
hi On Wed, Sep 9, 2015 at 11:28 AM, Gerd Hoffmann <kraxel@redhat.com> wrote: > Kick off all grabbing logic from fullscreen mode. In the current state > it seems to create more problems than it solves though. Try running > qemu/gtk fullscreen on one head of a multihead host for example ... > > There probably was a reason the grab-on-fullscreen logic was added in > the first place. So please test and report any issues so we can try to > find a sane way to handle it. > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > ui/gtk.c | 6 ------ > 1 file changed, 6 deletions(-) > I agree with you regarding multihead use case, so Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > diff --git a/ui/gtk.c b/ui/gtk.c > index 2629d97..a17b1d1 100644 > --- a/ui/gtk.c > +++ b/ui/gtk.c > @@ -1140,10 +1140,6 @@ static void gd_menu_full_screen(GtkMenuItem *item, void *opaque) > gtk_widget_hide(s->menu_bar); > if (vc->type == GD_VC_GFX) { > gtk_widget_set_size_request(vc->gfx.drawing_area, -1, -1); > - if (qemu_console_is_graphic(vc->gfx.dcl.con)) { > - gtk_check_menu_item_set_active > - (GTK_CHECK_MENU_ITEM(s->grab_item), TRUE); > - } > } > gtk_window_fullscreen(GTK_WINDOW(s->window)); > s->full_screen = TRUE; > @@ -1156,8 +1152,6 @@ static void gd_menu_full_screen(GtkMenuItem *item, void *opaque) > vc->gfx.scale_x = 1.0; > vc->gfx.scale_y = 1.0; > gd_update_windowsize(vc); > - gtk_check_menu_item_set_active(GTK_CHECK_MENU_ITEM(s->grab_item), > - FALSE); > } > } > > -- > 1.8.3.1 > >
diff --git a/ui/gtk.c b/ui/gtk.c index 2629d97..a17b1d1 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1140,10 +1140,6 @@ static void gd_menu_full_screen(GtkMenuItem *item, void *opaque) gtk_widget_hide(s->menu_bar); if (vc->type == GD_VC_GFX) { gtk_widget_set_size_request(vc->gfx.drawing_area, -1, -1); - if (qemu_console_is_graphic(vc->gfx.dcl.con)) { - gtk_check_menu_item_set_active - (GTK_CHECK_MENU_ITEM(s->grab_item), TRUE); - } } gtk_window_fullscreen(GTK_WINDOW(s->window)); s->full_screen = TRUE; @@ -1156,8 +1152,6 @@ static void gd_menu_full_screen(GtkMenuItem *item, void *opaque) vc->gfx.scale_x = 1.0; vc->gfx.scale_y = 1.0; gd_update_windowsize(vc); - gtk_check_menu_item_set_active(GTK_CHECK_MENU_ITEM(s->grab_item), - FALSE); } }
Kick off all grabbing logic from fullscreen mode. In the current state it seems to create more problems than it solves though. Try running qemu/gtk fullscreen on one head of a multihead host for example ... There probably was a reason the grab-on-fullscreen logic was added in the first place. So please test and report any issues so we can try to find a sane way to handle it. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- ui/gtk.c | 6 ------ 1 file changed, 6 deletions(-)