diff mbox

crypto: vmx - VMX crypto should depend on CONFIG_VSX

Message ID 1441779323-901-1-git-send-email-mpe@ellerman.id.au (mailing list archive)
State Superseded
Headers show

Commit Message

Michael Ellerman Sept. 9, 2015, 6:15 a.m. UTC
This code uses FP (floating point), Altivec and VSX. It can just depend on
CONFIG_VSX though, because that already depends on FP and Altivec.

Otherwise we get lots of link errors such as:

  drivers/built-in.o: In function `.p8_aes_setkey':
  aes.c:(.text+0x2d325c): undefined reference to `.enable_kernel_altivec'
  aes.c:(.text+0x2d326c): undefined reference to `.enable_kernel_vsx'

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 drivers/crypto/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Herbert Xu Sept. 9, 2015, 6:16 a.m. UTC | #1
On Wed, Sep 09, 2015 at 04:15:23PM +1000, Michael Ellerman wrote:
> This code uses FP (floating point), Altivec and VSX. It can just depend on
> CONFIG_VSX though, because that already depends on FP and Altivec.
> 
> Otherwise we get lots of link errors such as:
> 
>   drivers/built-in.o: In function `.p8_aes_setkey':
>   aes.c:(.text+0x2d325c): undefined reference to `.enable_kernel_altivec'
>   aes.c:(.text+0x2d326c): undefined reference to `.enable_kernel_vsx'
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

Could you please cc linux-crypto@vger.kernel.org?

Thanks,
diff mbox

Patch

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 07bc7aa6b224..d234719065a5 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -461,7 +461,7 @@  config CRYPTO_DEV_QCE
 
 config CRYPTO_DEV_VMX
 	bool "Support for VMX cryptographic acceleration instructions"
-	depends on PPC64
+	depends on PPC64 && VSX
 	help
 	  Support for VMX cryptographic acceleration instructions.