diff mbox

[U-Boot,1/4] thermal: imx_thermal: Do not print on error

Message ID 1441734192-21326-1-git-send-email-fabio.estevam@freescale.com
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Commit Message

Fabio Estevam Sept. 8, 2015, 5:43 p.m. UTC
It is not very useful to have the message below on every boot
(especially when we are using early silicon):

U-Boot 2015.10-rc2-23945-g37cf215 (Sep 08 2015 - 14:12:14 -0300)

CPU:   Freescale i.MX6UL rev1.0 792 MHz (running at 396 MHz)
CPU:   Commercial temperature grade (0C to 95C)CPU:   Thermal invalid data, fuse: 0x0
 - invalid sensor device

, so turn the error message into debug level.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/thermal/imx_thermal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefano Babic Sept. 13, 2015, 8:50 a.m. UTC | #1
On 08/09/2015 19:43, Fabio Estevam wrote:
> It is not very useful to have the message below on every boot
> (especially when we are using early silicon):
> 
> U-Boot 2015.10-rc2-23945-g37cf215 (Sep 08 2015 - 14:12:14 -0300)
> 
> CPU:   Freescale i.MX6UL rev1.0 792 MHz (running at 396 MHz)
> CPU:   Commercial temperature grade (0C to 95C)CPU:   Thermal invalid data, fuse: 0x0
>  - invalid sensor device
> 
> , so turn the error message into debug level.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/thermal/imx_thermal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
> index 3c6c967..04c43d7 100644
> --- a/drivers/thermal/imx_thermal.c
> +++ b/drivers/thermal/imx_thermal.c
> @@ -159,7 +159,7 @@ static int imx_thermal_probe(struct udevice *dev)
>  
>  	/* Check for valid fuse */
>  	if (fuse == 0 || fuse == ~0) {
> -		printf("CPU:   Thermal invalid data, fuse: 0x%x\n", fuse);
> +		debug("CPU:   Thermal invalid data, fuse: 0x%x\n", fuse);
>  		return -EPERM;
>  	}
>  
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
index 3c6c967..04c43d7 100644
--- a/drivers/thermal/imx_thermal.c
+++ b/drivers/thermal/imx_thermal.c
@@ -159,7 +159,7 @@  static int imx_thermal_probe(struct udevice *dev)
 
 	/* Check for valid fuse */
 	if (fuse == 0 || fuse == ~0) {
-		printf("CPU:   Thermal invalid data, fuse: 0x%x\n", fuse);
+		debug("CPU:   Thermal invalid data, fuse: 0x%x\n", fuse);
 		return -EPERM;
 	}