| Message ID | 1441695649-9892-5-git-send-email-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
On 2015年09月08日 15:00, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > ptr is re-assigned just a few lines later, so remove the first > redundant initialisation of ptr > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/lib/src/fwts_acpi_tables.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c > index 3fa200b..0aab404 100644 > --- a/src/lib/src/fwts_acpi_tables.c > +++ b/src/lib/src/fwts_acpi_tables.c > @@ -533,7 +533,7 @@ static uint8_t *fwts_acpi_load_table_from_acpidump( > char buffer[128]; > uint8_t *table; > uint8_t *tmp = NULL; > - char *ptr = buffer; > + char *ptr; > size_t len = 0; > unsigned long long table_addr; > ptrdiff_t name_len; > Acked-by: Ivan Hu <ivan.hu@canonical.com>
On 09/08/2015 03:00 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > ptr is re-assigned just a few lines later, so remove the first > redundant initialisation of ptr > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/lib/src/fwts_acpi_tables.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c > index 3fa200b..0aab404 100644 > --- a/src/lib/src/fwts_acpi_tables.c > +++ b/src/lib/src/fwts_acpi_tables.c > @@ -533,7 +533,7 @@ static uint8_t *fwts_acpi_load_table_from_acpidump( > char buffer[128]; > uint8_t *table; > uint8_t *tmp = NULL; > - char *ptr = buffer; > + char *ptr; > size_t len = 0; > unsigned long long table_addr; > ptrdiff_t name_len; > Acked-by: Alex Hung <alex.hung@canonical.com>
diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c index 3fa200b..0aab404 100644 --- a/src/lib/src/fwts_acpi_tables.c +++ b/src/lib/src/fwts_acpi_tables.c @@ -533,7 +533,7 @@ static uint8_t *fwts_acpi_load_table_from_acpidump( char buffer[128]; uint8_t *table; uint8_t *tmp = NULL; - char *ptr = buffer; + char *ptr; size_t len = 0; unsigned long long table_addr; ptrdiff_t name_len;