Patchwork [1/2] vnc: Fix compile error on x86_64 with -D_VNC_DEBUG=1

login
register
mail settings
Submitter Corentin Chary
Date May 3, 2010, 12:31 p.m.
Message ID <1272889879-17563-1-git-send-email-corentincj@iksaif.net>
Download mbox | patch
Permalink /patch/51504/
State New
Headers show

Comments

Corentin Chary - May 3, 2010, 12:31 p.m.
cc1: warnings being treated as errors
vnc-auth-sasl.c: In function ‘vnc_client_write_sasl’:
vnc-auth-sasl.c:50: error: format ‘%d’ expects type ‘int’, but argument 4 has type ‘size_t’
vnc-auth-sasl.c:50: error: format ‘%d’ expects type ‘int’, but argument 5 has type ‘size_t’
make: *** [vnc-auth-sasl.o] Error 1

Signed-off-by: Corentin Chary <corentincj@iksaif.net>
---
 vnc-auth-sasl.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Anthony Liguori - May 3, 2010, 5:15 p.m.
On 05/03/2010 07:31 AM, Corentin Chary wrote:
> cc1: warnings being treated as errors
> vnc-auth-sasl.c: In function ‘vnc_client_write_sasl’:
> vnc-auth-sasl.c:50: error: format ‘%d’ expects type ‘int’, but argument 4 has type ‘size_t’
> vnc-auth-sasl.c:50: error: format ‘%d’ expects type ‘int’, but argument 5 has type ‘size_t’
> make: *** [vnc-auth-sasl.o] Error 1
>
> Signed-off-by: Corentin Chary<corentincj@iksaif.net>
>    

Applied 1/2.  Thanks.

Regards,

Anthony Liguori
> ---
>   vnc-auth-sasl.c |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/vnc-auth-sasl.c b/vnc-auth-sasl.c
> index acaac0c..a51ddc8 100644
> --- a/vnc-auth-sasl.c
> +++ b/vnc-auth-sasl.c
> @@ -47,7 +47,8 @@ long vnc_client_write_sasl(VncState *vs)
>   {
>       long ret;
>
> -    VNC_DEBUG("Write SASL: Pending output %p size %d offset %d Encoded: %p size %d offset %d\n",
> +    VNC_DEBUG("Write SASL: Pending output %p size %zd offset %zd "
> +              "Encoded: %p size %d offset %d\n",
>                 vs->output.buffer, vs->output.capacity, vs->output.offset,
>                 vs->sasl.encoded, vs->sasl.encodedLength, vs->sasl.encodedOffset);
>
>

Patch

diff --git a/vnc-auth-sasl.c b/vnc-auth-sasl.c
index acaac0c..a51ddc8 100644
--- a/vnc-auth-sasl.c
+++ b/vnc-auth-sasl.c
@@ -47,7 +47,8 @@  long vnc_client_write_sasl(VncState *vs)
 {
     long ret;
 
-    VNC_DEBUG("Write SASL: Pending output %p size %d offset %d Encoded: %p size %d offset %d\n",
+    VNC_DEBUG("Write SASL: Pending output %p size %zd offset %zd "
+              "Encoded: %p size %d offset %d\n",
               vs->output.buffer, vs->output.capacity, vs->output.offset,
               vs->sasl.encoded, vs->sasl.encodedLength, vs->sasl.encodedOffset);