diff mbox

[v5,07/14] blockjob: Add "completed" and "ret" in BlockJob

Message ID 1441611277-24596-8-git-send-email-famz@redhat.com
State New
Headers show

Commit Message

Fam Zheng Sept. 7, 2015, 7:34 a.m. UTC 
They are set when block_job_completed is called.

Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
 blockjob.c               | 3 +++
 include/block/blockjob.h | 9 +++++++++
 2 files changed, 12 insertions(+)

Comments

Max Reitz Sept. 11, 2015, 6:27 p.m. UTC | #1 
On 07.09.2015 09:34, Fam Zheng wrote:
> They are set when block_job_completed is called.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> Reviewed-by: John Snow <jsnow@redhat.com>
> ---
>  blockjob.c               | 3 +++
>  include/block/blockjob.h | 9 +++++++++
>  2 files changed, 12 insertions(+)

Reviewed-by: Max Reitz <mreitz@redhat.com>
diff mbox

Patch

diff --git a/blockjob.c b/blockjob.c
index ec12887..293b62a 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -95,6 +95,9 @@  void block_job_completed(BlockJob *job, int ret)
     BlockDriverState *bs = job->bs;
 
     assert(bs->job == job);
+    assert(!job->completed);
+    job->completed = true;
+    job->ret = ret;
     job->cb(job->opaque, ret);
     block_job_unref(job);
 }
diff --git a/include/block/blockjob.h b/include/block/blockjob.h
index a7b497c..f6e4c86 100644
--- a/include/block/blockjob.h
+++ b/include/block/blockjob.h
@@ -143,6 +143,15 @@  struct BlockJob {
 
     /** Reference count of the block job */
     int refcnt;
+
+    /* True if this job has reported completion by calling block_job_completed.
+     */
+    bool completed;
+
+    /* ret code passed to block_job_completed.
+     */
+    int ret;
+
 };
 
 /**