diff mbox

[U-Boot,v2,5/8] nios2: remove gp assignments in link script

Message ID 1441369343-4638-6-git-send-email-thomas@wytron.com.tw
State Superseded
Delegated to: Thomas Chou
Headers show

Commit Message

Thomas Chou Sept. 4, 2015, 12:22 p.m. UTC 
Since we don't use gp for small data with option "-G0",
we use gp as global data pointer. The _gp location is
not needed.

The ALIGN(16) was for gp only. It is removed, so that we
can get correct address of dtb in u-boot-dtb.bin image.

Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
---
 arch/nios2/cpu/u-boot.lds | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Marek Vasut Sept. 4, 2015, 2 p.m. UTC | #1 
On Friday, September 04, 2015 at 02:22:20 PM, Thomas Chou wrote:
> Since we don't use gp for small data with option "-G0",
> we use gp as global data pointer. The _gp location is
> not needed.
> 
> The ALIGN(16) was for gp only. It is removed, so that we
> can get correct address of dtb in u-boot-dtb.bin image.
> 
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> ---
>  arch/nios2/cpu/u-boot.lds | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/nios2/cpu/u-boot.lds b/arch/nios2/cpu/u-boot.lds
> index 6e174be..951785c 100644
> --- a/arch/nios2/cpu/u-boot.lds
> +++ b/arch/nios2/cpu/u-boot.lds
> @@ -50,9 +50,10 @@ SECTIONS
>  	  *(.gnu.linkonce.d*)
>  	}
> 
> -	. = ALIGN(16);
> -	_gp = .;			/* Global pointer addr */
> -	PROVIDE (gp = .);
> +	/* gp - Since we don't use gp for small data with option "-G0",

Please make the multiline comment match the kernel coding style:

/*
 * foo
 * bar
 */

Otherwise
Acked-by: Marek Vasut <marex@denx.de>

> +	 * we will use gp as global data pointer. The _gp location is
> +	 * not needed.
> +	 */
> 
>  	.sdata :
>  	{

Best regards,
Marek Vasut
diff mbox

Patch

diff --git a/arch/nios2/cpu/u-boot.lds b/arch/nios2/cpu/u-boot.lds
index 6e174be..951785c 100644
--- a/arch/nios2/cpu/u-boot.lds
+++ b/arch/nios2/cpu/u-boot.lds
@@ -50,9 +50,10 @@  SECTIONS
 	  *(.gnu.linkonce.d*)
 	}
 
-	. = ALIGN(16);
-	_gp = .;			/* Global pointer addr */
-	PROVIDE (gp = .);
+	/* gp - Since we don't use gp for small data with option "-G0",
+	 * we will use gp as global data pointer. The _gp location is
+	 * not needed.
+	 */
 
 	.sdata :
 	{