| Message ID | 1441305318-24773-1-git-send-email-festevam@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
2015-09-04 3:35 GMT+09:00 Fabio Estevam <festevam@gmail.com>: > From: Fabio Estevam <fabio.estevam@freescale.com> > > Add a sentinel to ab85xx_rtc_ids[] in order to fix the following error: > > drivers/rtc/rtc-ab8500: struct platform_device_id is 24 bytes. The last of 2 is: > 0x61 0x62 0x38 0x35 0x34 0x30 0x2d 0x72 0x74 0x63 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x8c > FATAL: drivers/rtc/rtc-ab8500: struct platform_device_id is not terminated with a NULL entry! > > Reported-by: Olof's autobuilder <build@lixom.net> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > drivers/rtc/rtc-ab8500.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> However this was also reported earlier by: Andrey Ryabinin <ryabinin.a.a@gmail.com> http://www.spinics.net/lists/arm-kernel/msg441707.html Could you give him the credits as well? Best regards, Krzysztof
On Thu, Sep 3, 2015 at 8:35 PM, Fabio Estevam <festevam@gmail.com> wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > Add a sentinel to ab85xx_rtc_ids[] in order to fix the following error: > > drivers/rtc/rtc-ab8500: struct platform_device_id is 24 bytes. The last of 2 is: > 0x61 0x62 0x38 0x35 0x34 0x30 0x2d 0x72 0x74 0x63 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x8c > FATAL: drivers/rtc/rtc-ab8500: struct platform_device_id is not terminated with a NULL entry! > > Reported-by: Olof's autobuilder <build@lixom.net> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c index 8537d1e..51407c4 100644 --- a/drivers/rtc/rtc-ab8500.c +++ b/drivers/rtc/rtc-ab8500.c @@ -445,6 +445,7 @@ static const struct rtc_class_ops ab8540_rtc_ops = { static const struct platform_device_id ab85xx_rtc_ids[] = { { "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, }, { "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, }, + { /* sentinel */ } }; MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids);