| Message ID | 1441285740-23686-2-git-send-email-sr@denx.de |
|---|---|
| State | Accepted |
| Delegated to: | Stefan Roese |
| Headers | show |
On Thursday, September 03, 2015 at 03:08:55 PM, Stefan Roese wrote: > Instead of calling board_init_r() directly from board_init_f(), just > return from board_init_f(). This will make the code continue executing > in crt0.S _main(), from which the board_init_r() is called. This patch > aligns the MVEBU SPL with the correct SPL design as well as reduces > the stack utilisation slightly. > > Signed-off-by: Stefan Roese <sr@denx.de> > Cc: Marek Vasut <marex@denx.de> > Cc: Simon Glass <sjg@chromium.org> > Cc: Luka Perkov <luka.perkov@sartura.hr> > --- Acked-by: Marek Vasut <marex@denx.de> Best regards, Marek Vasut
On 3 September 2015 at 07:11, Marek Vasut <marex@denx.de> wrote: > On Thursday, September 03, 2015 at 03:08:55 PM, Stefan Roese wrote: >> Instead of calling board_init_r() directly from board_init_f(), just >> return from board_init_f(). This will make the code continue executing >> in crt0.S _main(), from which the board_init_r() is called. This patch >> aligns the MVEBU SPL with the correct SPL design as well as reduces >> the stack utilisation slightly. >> >> Signed-off-by: Stefan Roese <sr@denx.de> >> Cc: Marek Vasut <marex@denx.de> >> Cc: Simon Glass <sjg@chromium.org> >> Cc: Luka Perkov <luka.perkov@sartura.hr> >> --- > > Acked-by: Marek Vasut <marex@denx.de> Great! Acked-by: Simon Glass <sjg@chromium.org>
diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c index 26ff1a2..e273339 100644 --- a/arch/arm/mach-mvebu/spl.c +++ b/arch/arm/mach-mvebu/spl.c @@ -78,6 +78,4 @@ void board_init_f(ulong dummy) */ return_to_bootrom(); #endif - - board_init_r(NULL, 0); }
Instead of calling board_init_r() directly from board_init_f(), just return from board_init_f(). This will make the code continue executing in crt0.S _main(), from which the board_init_r() is called. This patch aligns the MVEBU SPL with the correct SPL design as well as reduces the stack utilisation slightly. Signed-off-by: Stefan Roese <sr@denx.de> Cc: Marek Vasut <marex@denx.de> Cc: Simon Glass <sjg@chromium.org> Cc: Luka Perkov <luka.perkov@sartura.hr> --- arch/arm/mach-mvebu/spl.c | 2 -- 1 file changed, 2 deletions(-)