| Message ID | 1441281857-613-1-git-send-email-jiri@resnulli.us |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On 9/3/2015 5:04 AM, Jiri Pirko wrote: > From: Jiri Pirko <jiri@mellanox.com> > > switchdev_port_fdb_dump is used as .ndo_fdb_dump. Its return value is > idx, so we cannot return errval. > > Fixes: 45d4122ca7cd ("switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.") > Signed-off-by: Jiri Pirko <jiri@mellanox.com> Acked-by: Sridhar Samudrala <sridhar.samudrala@intel.com> > --- > net/switchdev/switchdev.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c > index 16c1c43..fda38f8 100644 > --- a/net/switchdev/switchdev.c > +++ b/net/switchdev/switchdev.c > @@ -853,12 +853,8 @@ int switchdev_port_fdb_dump(struct sk_buff *skb, struct netlink_callback *cb, > .cb = cb, > .idx = idx, > }; > - int err; > - > - err = switchdev_port_obj_dump(dev, &dump.obj); > - if (err) > - return err; > > + switchdev_port_obj_dump(dev, &dump.obj); > return dump.idx; > } > EXPORT_SYMBOL_GPL(switchdev_port_fdb_dump); -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Sep 3, 2015 at 5:04 AM, Jiri Pirko <jiri@resnulli.us> wrote: > From: Jiri Pirko <jiri@mellanox.com> > > switchdev_port_fdb_dump is used as .ndo_fdb_dump. Its return value is > idx, so we cannot return errval. > > Fixes: 45d4122ca7cd ("switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.") > Signed-off-by: Jiri Pirko <jiri@mellanox.com> Acked-by: Scott Feldman<sfeldma@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Jiri Pirko <jiri@resnulli.us> Date: Thu, 3 Sep 2015 14:04:17 +0200 > From: Jiri Pirko <jiri@mellanox.com> > > switchdev_port_fdb_dump is used as .ndo_fdb_dump. Its return value is > idx, so we cannot return errval. > > Fixes: 45d4122ca7cd ("switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.") > Signed-off-by: Jiri Pirko <jiri@mellanox.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c index 16c1c43..fda38f8 100644 --- a/net/switchdev/switchdev.c +++ b/net/switchdev/switchdev.c @@ -853,12 +853,8 @@ int switchdev_port_fdb_dump(struct sk_buff *skb, struct netlink_callback *cb, .cb = cb, .idx = idx, }; - int err; - - err = switchdev_port_obj_dump(dev, &dump.obj); - if (err) - return err; + switchdev_port_obj_dump(dev, &dump.obj); return dump.idx; } EXPORT_SYMBOL_GPL(switchdev_port_fdb_dump);