| Message ID | 34042a90627862a05815f38fea948493777bdf4c.1441253454.git.baruch@tkos.co.il |
|---|---|
| State | Accepted |
| Commit | 708818aaa287b17d607ee35b57fef194e38f1055 |
| Headers | show |
Dear Baruch Siach, On 09/03/2015 05:10 AM, Baruch Siach wrote: > This shortens build time. > > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > --- > v3: > * New patch in this series (Peter) > --- > package/dos2unix/dos2unix.mk | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/package/dos2unix/dos2unix.mk b/package/dos2unix/dos2unix.mk > index 4c5f4fcff384..55608c653f9c 100644 > --- a/package/dos2unix/dos2unix.mk > +++ b/package/dos2unix/dos2unix.mk > @@ -9,7 +9,7 @@ DOS2UNIX_SITE = http://waterlan.home.xs4all.nl/dos2unix > DOS2UNIX_LICENSE = BSD-2c > DOS2UNIX_LICENSE_FILES = COPYING.txt > DOS2UNIX_DEPENDENCIES = $(if $(BR2_PACKAGE_BUSYBOX),busybox) > -HOST_DOS2UNIX_DEPENDENCIES = host-gettext > +HOST_DOS2UNIX_DEPENDENCIES = > > ifeq ($(BR2_ENABLE_LOCALE),) > DOS2UNIX_MAKE_OPTS += ENABLE_NLS= > @@ -34,11 +34,12 @@ define DOS2UNIX_INSTALL_TARGET_CMDS > endef > > define HOST_DOS2UNIX_BUILD_CMDS > - $(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) > + $(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) ENABLE_NLS= > endef > > define HOST_DOS2UNIX_INSTALL_CMDS > - $(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(HOST_DIR) install > + $(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(HOST_DIR) ENABLE_NLS= \ > + install > endef > > $(eval $(generic-package)) > Reviewed-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> Tested-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> Compile test for MIPS architecture: $ grep gettext output/build/build-time.log $ $ grep host-dos2unix output/build/build-time.log | grep install 1441363609:start:install-host : host-dos2unix 1441363609:end :install-host : host-dos2unix However I think your commit message is not correct. What your patch does is disable the native language support therefore there is no need to depend on gettext. Perhaps you could improve your commit message. Anyway you can keep my reviewed-by and tested-by. Regards, Vincent.
diff --git a/package/dos2unix/dos2unix.mk b/package/dos2unix/dos2unix.mk index 4c5f4fcff384..55608c653f9c 100644 --- a/package/dos2unix/dos2unix.mk +++ b/package/dos2unix/dos2unix.mk @@ -9,7 +9,7 @@ DOS2UNIX_SITE = http://waterlan.home.xs4all.nl/dos2unix DOS2UNIX_LICENSE = BSD-2c DOS2UNIX_LICENSE_FILES = COPYING.txt DOS2UNIX_DEPENDENCIES = $(if $(BR2_PACKAGE_BUSYBOX),busybox) -HOST_DOS2UNIX_DEPENDENCIES = host-gettext +HOST_DOS2UNIX_DEPENDENCIES = ifeq ($(BR2_ENABLE_LOCALE),) DOS2UNIX_MAKE_OPTS += ENABLE_NLS= @@ -34,11 +34,12 @@ define DOS2UNIX_INSTALL_TARGET_CMDS endef define HOST_DOS2UNIX_BUILD_CMDS - $(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) + $(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) ENABLE_NLS= endef define HOST_DOS2UNIX_INSTALL_CMDS - $(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(HOST_DIR) install + $(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(HOST_DIR) ENABLE_NLS= \ + install endef $(eval $(generic-package))
This shortens build time. Signed-off-by: Baruch Siach <baruch@tkos.co.il> --- v3: * New patch in this series (Peter) --- package/dos2unix/dos2unix.mk | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)