diff mbox

[01/17] target-openrisc: Always enable OPENRISC_DISAS

Message ID 1441239463-18981-2-git-send-email-rth@twiddle.net
State New
Headers show

Commit Message

Richard Henderson Sept. 3, 2015, 12:17 a.m. UTC 
Avoids warnings from unused variables etc.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 target-openrisc/translate.c | 20 ++++----------------
 1 file changed, 4 insertions(+), 16 deletions(-)

Comments

Bastian Koppelmann Sept. 3, 2015, 2:15 p.m. UTC | #1 
On 09/03/2015 02:17 AM, Richard Henderson wrote:
> Avoids warnings from unused variables etc.
>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>   target-openrisc/translate.c | 20 ++++----------------
>   1 file changed, 4 insertions(+), 16 deletions(-)
>
>
Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>

Cheers,
Bastian
diff mbox

Patch

diff --git a/target-openrisc/translate.c b/target-openrisc/translate.c
index aca1242..9d04753 100644
--- a/target-openrisc/translate.c
+++ b/target-openrisc/translate.c
@@ -33,14 +33,9 @@ 
 
 #include "trace-tcg.h"
 
-
-#define OPENRISC_DISAS
-
-#ifdef OPENRISC_DISAS
-#  define LOG_DIS(...) qemu_log_mask(CPU_LOG_TB_IN_ASM, ## __VA_ARGS__)
-#else
-#  define LOG_DIS(...) do { } while (0)
-#endif
+/* Set to 0 to completely disable.  */
+#define OPENRISC_DISAS  CPU_LOG_TB_IN_ASM
+#define LOG_DIS(...) qemu_log_mask(OPENRISC_DISAS, ## __VA_ARGS__)
 
 typedef struct DisasContext {
     TranslationBlock *tb;
@@ -704,9 +699,7 @@  static void dec_misc(DisasContext *dc, uint32_t insn)
 {
     uint32_t op0, op1;
     uint32_t ra, rb, rd;
-#ifdef OPENRISC_DISAS
     uint32_t L6, K5;
-#endif
     uint32_t I16, I5, I11, N26, tmp;
     TCGMemOp mop;
 
@@ -715,10 +708,8 @@  static void dec_misc(DisasContext *dc, uint32_t insn)
     ra = extract32(insn, 16, 5);
     rb = extract32(insn, 11, 5);
     rd = extract32(insn, 21, 5);
-#ifdef OPENRISC_DISAS
     L6 = extract32(insn, 5, 6);
     K5 = extract32(insn, 0, 5);
-#endif
     I16 = extract32(insn, 0, 16);
     I5 = extract32(insn, 21, 5);
     I11 = extract32(insn, 0, 11);
@@ -1315,13 +1306,10 @@  static void dec_compi(DisasContext *dc, uint32_t insn)
 static void dec_sys(DisasContext *dc, uint32_t insn)
 {
     uint32_t op0;
-#ifdef OPENRISC_DISAS
     uint32_t K16;
-#endif
+
     op0 = extract32(insn, 16, 10);
-#ifdef OPENRISC_DISAS
     K16 = extract32(insn, 0, 16);
-#endif
 
     switch (op0) {
     case 0x000:    /* l.sys */