| Message ID | 1441210493-19591-7-git-send-email-stefanha@redhat.com |
|---|---|
| State | New |
| Headers | show |
Hi, On Wed, 2 Sep 2015 17:14:52 +0100, stefanha@redhat.com wrote: > From: Fam Zheng <famz@redhat.com> > > Commit 6e99c63 ("net/socket: Drop net_socket_can_send") changed the > semantics around .can_receive for sockets to now require the device to > flush queued pkts when transitioning to a .can_receive=true state. But > it's OK to drop incoming packets when the link is not active. > > Signed-off-by: Fam Zheng <famz@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Tested-by: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
Hi, On Thu, 3 Sep 2015 10:19:19 +0300, shmulik.ladkani@ravellosystems.com wrote: > On Wed, 2 Sep 2015 17:14:52 +0100, stefanha@redhat.com wrote: > > From: Fam Zheng <famz@redhat.com> > > > > Commit 6e99c63 ("net/socket: Drop net_socket_can_send") changed the > > semantics around .can_receive for sockets to now require the device to > > flush queued pkts when transitioning to a .can_receive=true state. But > > it's OK to drop incoming packets when the link is not active. > > > > Signed-off-by: Fam Zheng <famz@redhat.com> > > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> > > Tested-by: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com> Ping... I'm not sure what's the exact policy, but shouldn't '2734a20 vmxnet3: Drop net_vmxnet3_info.can_receive' go into stable-2.4? Otherwise, vmxnet3 has no rx connectivity in 2.4 based releases. See here: https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg02233.html Regards, Shmulik
On 09/24/2015 07:19 PM, Shmulik Ladkani wrote: > Hi, > > On Thu, 3 Sep 2015 10:19:19 +0300, shmulik.ladkani@ravellosystems.com wrote: >> On Wed, 2 Sep 2015 17:14:52 +0100, stefanha@redhat.com wrote: >>> From: Fam Zheng <famz@redhat.com> >>> >>> Commit 6e99c63 ("net/socket: Drop net_socket_can_send") changed the >>> semantics around .can_receive for sockets to now require the device to >>> flush queued pkts when transitioning to a .can_receive=true state. But >>> it's OK to drop incoming packets when the link is not active. >>> >>> Signed-off-by: Fam Zheng <famz@redhat.com> >>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> >> Tested-by: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com> > Ping... > > I'm not sure what's the exact policy, but shouldn't > '2734a20 vmxnet3: Drop net_vmxnet3_info.can_receive' go into stable-2.4? If you think a patch is stable candidate. Need cc qemu-stable@nongnu.org explicitly in the commit log. Cc Michael for this. > > Otherwise, vmxnet3 has no rx connectivity in 2.4 based releases. > > See here: > https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg02233.html > > Regards, > Shmulik
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 071feeb..04159c8 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -1988,7 +1988,6 @@ static void vmxnet3_set_link_status(NetClientState *nc) static NetClientInfo net_vmxnet3_info = { .type = NET_CLIENT_OPTIONS_KIND_NIC, .size = sizeof(NICState), - .can_receive = vmxnet3_can_receive, .receive = vmxnet3_receive, .link_status_changed = vmxnet3_set_link_status, };