From patchwork Fri Apr 30 14:00:40 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Wolf X-Patchwork-Id: 51346 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2451AB7D12 for ; Sat, 1 May 2010 00:35:52 +1000 (EST) Received: from localhost ([127.0.0.1]:58929 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O7rJl-0002oo-CV for incoming@patchwork.ozlabs.org; Fri, 30 Apr 2010 10:35:49 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O7qo3-0007xi-15 for qemu-devel@nongnu.org; Fri, 30 Apr 2010 10:03:03 -0400 Received: from [140.186.70.92] (port=55324 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O7qo1-0007wj-Ae for qemu-devel@nongnu.org; Fri, 30 Apr 2010 10:03:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O7qnz-0000Yx-MV for qemu-devel@nongnu.org; Fri, 30 Apr 2010 10:03:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17410) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O7qnz-0000Yn-EG for qemu-devel@nongnu.org; Fri, 30 Apr 2010 10:02:59 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3UE2tTQ010239 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 30 Apr 2010 10:02:57 -0400 Received: from localhost.localdomain (vpn1-6-55.ams2.redhat.com [10.36.6.55]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3UE14sH007196; Fri, 30 Apr 2010 10:02:54 -0400 From: Kevin Wolf To: aliguori@linux.vnet.ibm.com Date: Fri, 30 Apr 2010 16:00:40 +0200 Message-Id: <1272636040-17374-19-git-send-email-kwolf@redhat.com> In-Reply-To: <1272636040-17374-1-git-send-email-kwolf@redhat.com> References: <1272636040-17374-1-git-send-email-kwolf@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.17 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: kwolf@redhat.com, qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 18/18] block: Release allocated options after bdrv_open X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Jan Kiszka They aren't used afterwards nor supposed to be stored by a bdrv_create handler. Signed-off-by: Jan Kiszka Signed-off-by: Kevin Wolf --- block.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index f463ec4..48305b7 100644 --- a/block.c +++ b/block.c @@ -540,6 +540,7 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags, } ret = bdrv_create(bdrv_qcow2, tmp_filename, options); + free_option_parameters(options); if (ret < 0) { return ret; }