diff mbox

package/clapack: fix comments

Message ID 1441188607-9953-1-git-send-email-yann.morin.1998@free.fr
State Accepted
Commit d58d667acaebdd8fac0d59f1d40e4a0a3bae5a58
Headers show

Commit Message

Yann E. MORIN Sept. 2, 2015, 10:10 a.m. UTC 
Provide appropriate comments for the powerpc and !powerpc cases.

Adapt armadillo's comments accordingly.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Samuel Martin <s.martin49@gmail.com>
---
 package/armadillo/Config.in | 12 ++++++++----
 package/clapack/Config.in   |  8 ++++++--
 2 files changed, 14 insertions(+), 6 deletions(-)

Comments

Samuel Martin Sept. 2, 2015, 10:44 a.m. UTC | #1 
On Wed, Sep 2, 2015 at 12:10 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Provide appropriate comments for the powerpc and !powerpc cases.
>
> Adapt armadillo's comments accordingly.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Samuel Martin <s.martin49@gmail.com>

Reviewed-by: Samuel Martin <s.martin49@gmail.com>
Peter Korsgaard Sept. 4, 2015, 9:59 a.m. UTC | #2 
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Provide appropriate comments for the powerpc and !powerpc cases.
 > Adapt armadillo's comments accordingly.

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: Samuel Martin <s.martin49@gmail.com>

Committed, thanks.
diff mbox

Patch

diff --git a/package/armadillo/Config.in b/package/armadillo/Config.in
index e49997d..18bf750 100644
--- a/package/armadillo/Config.in
+++ b/package/armadillo/Config.in
@@ -1,14 +1,18 @@ 
 comment "armadillo needs a toolchain w/ C++"
 	depends on !BR2_INSTALL_LIBSTDCPP
-	depends on !(BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el) # clapack
-	depends on !(BR2_powerpc && BR2_TOOLCHAIN_USES_UCLIBC) # clapack
-	depends on !BR2_bfin # clapack
+	depends on !(BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el)
+	depends on !BR2_powerpc
+	depends on !BR2_bfin
+
+comment "armadillo needs an (e)glibc toolchain w/ C++"
+	depends on BR2_powerpc
+	depends on !BR2_INSTALL_LIBSTDCPP || BR2_TOOLCHAIN_USES_UCLIBC
 
 config BR2_PACKAGE_ARMADILLO
 	bool "armadillo"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on !(BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el) # clapack
-	depends on !(BR2_powerpc && BR2_TOOLCHAIN_USES_UCLIBC) # clapack
+	depends on !BR2_powerpc || BR2_TOOLCHAIN_USES_GLIBC # clapack
 	depends on !BR2_bfin # clapack
 	select BR2_PACKAGE_CLAPACK
 	help
diff --git a/package/clapack/Config.in b/package/clapack/Config.in
index f37752a..2257524 100644
--- a/package/clapack/Config.in
+++ b/package/clapack/Config.in
@@ -1,9 +1,13 @@ 
+comment "clapack needs an (e)glibc toolchain"
+	depends on BR2_powerpc
+	depends on !BR2_TOOLCHAIN_USES_GLIBC
+
 config BR2_PACKAGE_CLAPACK
 	bool "cblas/clapack"
 	depends on !(BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el)
 	# _fpu_control is used on PowerPC, but not available with
-	# uClibc
-	depends on !(BR2_powerpc && BR2_TOOLCHAIN_USES_UCLIBC)
+	# uClibc or musl
+	depends on !BR2_powerpc || BR2_TOOLCHAIN_USES_GLIBC
 	# disable clapack on blackfin, it triggers "undefined symbol" failure
 	# because of the "_" symbol prefix:
 	# http://autobuild.buildroot.net/results/a28df0ba10803e6e54c2f8160bbd8190cba4d690/