From patchwork Thu Apr 29 23:49:34 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anatolij Gustschin X-Patchwork-Id: 51309 X-Patchwork-Delegate: grant.likely@secretlab.ca Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from bilbo.ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 82B4FB7F0D for ; Fri, 30 Apr 2010 09:49:51 +1000 (EST) Received: by ozlabs.org (Postfix) id 0C223B7D4F; Fri, 30 Apr 2010 09:49:39 +1000 (EST) Delivered-To: linuxppc-dev@ozlabs.org Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by ozlabs.org (Postfix) with ESMTP id AF5CDB7D1D for ; Fri, 30 Apr 2010 09:49:37 +1000 (EST) Received: from mail01.m-online.net (mail.m-online.net [192.168.3.149]) by mail-out.m-online.net (Postfix) with ESMTP id 351F01C003B4; Fri, 30 Apr 2010 01:49:35 +0200 (CEST) X-Auth-Info: lplE6pc2behZ32dYGTevMKYV2Tsv+vR1VShMUw0fc6Y= Received: from localhost (pD953C7F7.dip.t-dialin.net [217.83.199.247]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTP id 0E0AF902BD; Fri, 30 Apr 2010 01:49:35 +0200 (CEST) From: Anatolij Gustschin To: linuxppc-dev@ozlabs.org Subject: [PATCH 1/5] fsl-diu-fb: fix issue with re-enabling DIU area descriptor on MPC5121 Date: Fri, 30 Apr 2010 01:49:34 +0200 Message-Id: <1272584978-19063-2-git-send-email-agust@denx.de> X-Mailer: git-send-email 1.6.3.3 In-Reply-To: <1272584978-19063-1-git-send-email-agust@denx.de> References: <1272584978-19063-1-git-send-email-agust@denx.de> Cc: linux-fbdev@vger.kernel.org, wd@denx.de, dzu@denx.de, devicetree-discuss@lists.ozlabs.org, yorksun@freescale.com X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org On MPC5121 re-configuring the DIU area descriptor by writing new descriptor address doesn't work. As a result, DIU continues to display using old area descriptor even if the new one has been set. Disabling the DIU before setting the new descriptor and subsequently enabling it fixes the problem. Signed-off-by: Anatolij Gustschin --- drivers/video/fsl-diu-fb.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/video/fsl-diu-fb.c b/drivers/video/fsl-diu-fb.c index 994358a..ee15a99 100644 --- a/drivers/video/fsl-diu-fb.c +++ b/drivers/video/fsl-diu-fb.c @@ -329,8 +329,11 @@ static int fsl_diu_enable_panel(struct fb_info *info) if (mfbi->type != MFB_TYPE_OFF) { switch (mfbi->index) { case 0: /* plane 0 */ - if (hw->desc[0] != ad->paddr) + if (hw->desc[0] != ad->paddr) { + out_be32(&dr.diu_reg->diu_mode, MFB_MODE0); out_be32(&hw->desc[0], ad->paddr); + out_be32(&dr.diu_reg->diu_mode, MFB_MODE1); + } break; case 1: /* plane 1 AOI 0 */ cmfbi = machine_data->fsl_diu_info[2]->par;