diff mbox

[gomp4] New reduction infrastructure for OpenACC

Message ID 55E5D0FD.5000408@mentor.com
State New
Headers show

Commit Message

Tom de Vries Sept. 1, 2015, 4:23 p.m. UTC 
On 01/09/15 14:53, Tom de Vries wrote:
> On 19/08/15 21:42, Cesar Philippidis wrote:
>> +DEFHOOK
>> +(reduction,
>> +"This hook is used by the oacc_transform pass to expand calls to the\n\
>> +internal functions @var{GOACC_REDUCTION_SETUP},\n\
>> +@var{GOACC_REDUCTION_INIT},\n\ @var{GOACC_REDUCTION_FINI} and\n\
>> @var{GOACC_REDUCTION_TEARDOWN} into a sequence of gimple
>> instructions.\n\ @var{call} is gimple statement containing the call to
>> the function.  This\n\ hook removes statement @var{call} after the
>> expanded sequence has been\n\ inserted.  This hook is also responsible
>> for allocating any storage for\n\ reductions when necessary.  It
>> returns @var{true} if the expanded\n\
>> +sequence introduces any calls to OpenACC-specific internal functions.",
>> +bool, (gimple call),
>> +default_goacc_reduction)
>> +
>
> This causes a gomp-4_0-branch bootstrap error:
> ...
> src/gcc/target.def:1685:1: error: unknown escape sequence: '\040' [-Werror]
> ...
>
> Currently testing attached patch, which allows 'make build/genhooks.o'
> to succeed.
>

Committed as attached.

Thanks,
- Tom
diff mbox

Patch

Fix unknown escape sequence error in DEFHOOK reduction

2015-09-01  Tom de Vries  <tom@codesourcery.com>

	* target.def: Fix unknown escape sequence \040 error in reduction
	DEFHOOK.
	* doc/tm.texi: Regenerate.
---
 gcc/doc/tm.texi | 12 ++++++------
 gcc/target.def  |  8 +++++++-
 2 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/gcc/doc/tm.texi b/gcc/doc/tm.texi
index f53a54e..a151a10 100644
--- a/gcc/doc/tm.texi
+++ b/gcc/doc/tm.texi
@@ -5772,12 +5772,12 @@  is no RTL expanders for them.
 This hook is used by the oacc_transform pass to expand calls to the
 internal functions @var{GOACC_REDUCTION_SETUP},
 @var{GOACC_REDUCTION_INIT},
- @var{GOACC_REDUCTION_FINI} and
- @var{GOACC_REDUCTION_TEARDOWN} into a sequence of gimple instructions.
- @var{call} is gimple statement containing the call to the function.  This
- hook removes statement @var{call} after the expanded sequence has been
- inserted.  This hook is also responsible for allocating any storage for
- reductions when necessary.  It returns @var{true} if the expanded
+@var{GOACC_REDUCTION_FINI} and
+@var{GOACC_REDUCTION_TEARDOWN} into a sequence of gimple instructions.
+@var{call} is gimple statement containing the call to the function.  This
+hook removes statement @var{call} after the expanded sequence has been
+inserted.  This hook is also responsible for allocating any storage for
+reductions when necessary.  It returns @var{true} if the expanded
 sequence introduces any calls to OpenACC-specific internal functions.
 @end deftypefn
 
diff --git a/gcc/target.def b/gcc/target.def
index 22e04f6..80b401f 100644
--- a/gcc/target.def
+++ b/gcc/target.def
@@ -1684,7 +1684,13 @@  DEFHOOK
 (reduction,
 "This hook is used by the oacc_transform pass to expand calls to the\n\
 internal functions @var{GOACC_REDUCTION_SETUP},\n\
-@var{GOACC_REDUCTION_INIT},\n\ @var{GOACC_REDUCTION_FINI} and\n\ @var{GOACC_REDUCTION_TEARDOWN} into a sequence of gimple instructions.\n\ @var{call} is gimple statement containing the call to the function.  This\n\ hook removes statement @var{call} after the expanded sequence has been\n\ inserted.  This hook is also responsible for allocating any storage for\n\ reductions when necessary.  It returns @var{true} if the expanded\n\
+@var{GOACC_REDUCTION_INIT},\n\
+@var{GOACC_REDUCTION_FINI} and\n\
+@var{GOACC_REDUCTION_TEARDOWN} into a sequence of gimple instructions.\n\
+@var{call} is gimple statement containing the call to the function.  This\n\
+hook removes statement @var{call} after the expanded sequence has been\n\
+inserted.  This hook is also responsible for allocating any storage for\n\
+reductions when necessary.  It returns @var{true} if the expanded\n\
 sequence introduces any calls to OpenACC-specific internal functions.",
 bool, (gimple call),
 default_goacc_reduction)
-- 
1.9.1