[ovs-dev] ovsdb: Remove misleading OVS_UNUSED from ovsdb_monitor_change_cb().
diff mbox

Message ID 1441039444-7671-1-git-send-email-blp@nicira.com
State Accepted
Headers show

Commit Message

Ben Pfaff Aug. 31, 2015, 4:44 p.m. UTC
This function does use this parameter.

(This does not change any behavior.)

Signed-off-by: Ben Pfaff <blp@nicira.com>
---
 ovsdb/monitor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andy Zhou Aug. 31, 2015, 9:36 p.m. UTC | #1
Acked-by: Andy Zhou <azhou@nicira.com>

On Mon, Aug 31, 2015 at 9:44 AM, Ben Pfaff <blp@nicira.com> wrote:
> This function does use this parameter.
>
> (This does not change any behavior.)
>
> Signed-off-by: Ben Pfaff <blp@nicira.com>
> ---
>  ovsdb/monitor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ovsdb/monitor.c b/ovsdb/monitor.c
> index 133460e..8a64fc1 100644
> --- a/ovsdb/monitor.c
> +++ b/ovsdb/monitor.c
> @@ -779,7 +779,7 @@ ovsdb_monitor_changes_classify(enum ovsdb_monitor_selection type,
>  static bool
>  ovsdb_monitor_change_cb(const struct ovsdb_row *old,
>                          const struct ovsdb_row *new,
> -                        const unsigned long int *changed OVS_UNUSED,
> +                        const unsigned long int *changed,
>                          void *aux_)
>  {
>      struct ovsdb_monitor_aux *aux = aux_;
> --
> 2.1.3
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
Ben Pfaff Aug. 31, 2015, 10:33 p.m. UTC | #2
Thanks, applied.

On Mon, Aug 31, 2015 at 02:36:28PM -0700, Andy Zhou wrote:
> Acked-by: Andy Zhou <azhou@nicira.com>
> 
> On Mon, Aug 31, 2015 at 9:44 AM, Ben Pfaff <blp@nicira.com> wrote:
> > This function does use this parameter.
> >
> > (This does not change any behavior.)
> >
> > Signed-off-by: Ben Pfaff <blp@nicira.com>
> > ---
> >  ovsdb/monitor.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/ovsdb/monitor.c b/ovsdb/monitor.c
> > index 133460e..8a64fc1 100644
> > --- a/ovsdb/monitor.c
> > +++ b/ovsdb/monitor.c
> > @@ -779,7 +779,7 @@ ovsdb_monitor_changes_classify(enum ovsdb_monitor_selection type,
> >  static bool
> >  ovsdb_monitor_change_cb(const struct ovsdb_row *old,
> >                          const struct ovsdb_row *new,
> > -                        const unsigned long int *changed OVS_UNUSED,
> > +                        const unsigned long int *changed,
> >                          void *aux_)
> >  {
> >      struct ovsdb_monitor_aux *aux = aux_;
> > --
> > 2.1.3
> >
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev

Patch
diff mbox

diff --git a/ovsdb/monitor.c b/ovsdb/monitor.c
index 133460e..8a64fc1 100644
--- a/ovsdb/monitor.c
+++ b/ovsdb/monitor.c
@@ -779,7 +779,7 @@  ovsdb_monitor_changes_classify(enum ovsdb_monitor_selection type,
 static bool
 ovsdb_monitor_change_cb(const struct ovsdb_row *old,
                         const struct ovsdb_row *new,
-                        const unsigned long int *changed OVS_UNUSED,
+                        const unsigned long int *changed,
                         void *aux_)
 {
     struct ovsdb_monitor_aux *aux = aux_;